[Mobile] - Image - Workaround for Android and orientation changes #42900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
the
Mobile App - i.e. Android or iOS
|
Size Change: 0 B Total Size: 1.27 MB ℹ️ View Unchanged
|
derekblank
approved these changes
Aug 3, 2022
There was a problem hiding this comment.
Nice quick fix, @geriux. I tested the changes and can confirm the image remains present when changing the device orientation.
I tried exploring the cause of the issue a bit more and couldn't trace it back to anything on the Javascript side. Leaving a note just for things to possibly explore in the future, as it could be related to an issue with the Android image library Glide, or the custom AppGlideModule within the WPAndroid app.
These changes look good to me however. Approving! 🚀
Thank you for testing and reviewing!
Yeah, I think it has to be related to that or around the code that implements the editor in WordPress Android, I know there are some parts where it does some things when the orientation changes so we'll need to check that as well. |
geriux
pushed a commit
that referenced
this pull request
Aug 3, 2022
4 tasks
geriux
pushed a commit
that referenced
this pull request
Aug 4, 2022
* Release script: Update react-native-editor version to 1.80.0 * Release script: Update with changes from 'npm run core preios' * Update CHANGELOG * Remove redundant space in CHANGELOG * Release script: Update react-native-editor version to 1.80.1 * Release script: Update with changes from 'npm run core preios' * Mobile - FastImage - Adds workaround for Android when the orientation changes (#42900) * Mobile - Update Changelog Co-authored-by: Siobhan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42869
What?
This PR adds a workaround for an issue on Android and FastImage when the device orientation changes.
Why?
Since this issue is happening in the current beta, I'm adding a workaround until we find out what the issue is. On Android, if the orientation changes somehow it breaks the FastImage component making the images to not be visible.
I considered disabling
FastImagefor Android but I think most users will use the device in portrait mode. We should still keep investigating what's happening on WordPress Android that breaks this. On the demo app, changing the orientation doesn't affect the FastImage component.How?
It adds a check in the
Imagecomponent only for Android, where it will check if the orientation changes, if it does and FastImage is enabled, it will set thefallbackprop to true, this will make the FastImage component to use the default Image component from React Native.Testing Instructions
Note: Test on both platforms to see if it works correctly.
LandscapeScreenshots or screencast
AndroidFastImage.mov