Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

List: Add missing typography block supports #43311

Merged
merged 1 commit into from
Sep 7, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing letter-spacing support to the List block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing letter spacing typography support.

Testing Instructions

  1. Edit a post, and add a List block with multiple items.
  2. Select the List block and confirm the letter spacing control is available.
  3. Test various typography settings ensuring styles are applied in the editor.
  4. Save and confirm the application on the frontend.
  5. Switch to the site editor and select a page with a List.
  6. Navigate to Global Styles > Blocks > List > Typography and apply typography styles there.
  7. Confirm the selected styles are reflected in the preview and on the frontend.

Screenshots or screencast

Screen.Recording.2022-08-17.at.6.54.35.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] List Affects the List Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Aug 17, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 17, 2022
@aaronrobertshaw aaronrobertshaw marked this pull request as ready for review August 17, 2022 08:56
Copy link
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. For List block:

✅ Letter spacing applied to list view in editor and frontend
✅ Letter spacing applied in global styles applied in site editor, post editor, and frontend
✅ Other typography supports worked as expected for list block

@aaronrobertshaw aaronrobertshaw merged commit ac872b8 into trunk Sep 7, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/missing-typography-supports-to-list branch September 7, 2022 01:49
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Sep 7, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] List Affects the List Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants