Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Comments Link: Add missing typography supports #43338

Merged

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing typography supports to the Post Comments Link block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing font-family and text-decoration typography support.

Testing Instructions

  1. In the site editor, add a Post Comments Links block to a template e.g Index page's posts.
  2. Navigate to Global Styles > Blocks > Post Comments Link > Typography.
  3. Apply a different font family and save. (Note, text decoration cannot be styled globally at this stage)
  4. Confirm font family style is applied to the count on the frontend.
  5. Reset Global Styles to defaults, select the Post Comments Link block within the preview.
  6. On the Block tab of the Settings sidebar, toggle on and test font-family and text decoration.

Screenshots or screencast

Screen.Recording.2022-08-18.at.9.23.41.am.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Aug 17, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 17, 2022
@carolinan carolinan merged commit f360185 into trunk Aug 18, 2022
@carolinan carolinan deleted the add/missing-typography-supports-to-post-comments-link branch August 18, 2022 08:43
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 18, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants