Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Post Template: Add typography supports #43342

Merged
merged 1 commit into from
Aug 19, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds typography supports to the Post Template block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into all typography supports.
  • Makes font size control displayed by default as per the majority of blocks currently.

Testing Instructions

  1. In the site editor, edit a template with a Post Template block, e.g. via a Query Loop.
  2. Navigate to Global Styles > Blocks > Post Template > Typography.
  3. Experiment with typography styles and ensure they are applied in the preview. (Note: Some inner blocks will have their own default styles that won't inherit from Post Template)
  4. Confirm styles on the frontend.
  5. Reset Global Styles to defaults, and select the Post Template block within the preview.
  6. On the Block tab of the Settings sidebar, test the typography controls for the individual block.

Screenshots or screencast

Screen.Recording.2022-08-18.at.10.54.14.am.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Post Template Affects the Post Template Block [Feature] Typography Font and typography-related issues and PRs labels Aug 18, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 18, 2022
Copy link
Contributor

@carolinan carolinan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well. Styles on the individual blocks inside the template correctly overrides the global styles.

@carolinan carolinan merged commit 1a50b66 into trunk Aug 19, 2022
@carolinan carolinan deleted the add/typography-supports-to-post-template branch August 19, 2022 01:30
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 19, 2022
@aaronrobertshaw
Copy link
Contributor Author

aaronrobertshaw commented Aug 19, 2022

Thanks for the reviews @carolinan 👍

I'm trying also to keep the tracking issue updated when merging these. I'm happy to merge and update the issues accordingly if you'd like to leave the extra wrangling to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Post Template Affects the Post Template Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants