Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Post Terms: Add missing typography supports #43343

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Post Terms: Add missing typography supports #43343

merged 1 commit into from
Aug 18, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing typography support to the Post Terms block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing typography supports.

Testing Instructions

  1. Within the site editor, edit a template with Post Terms blocks e.g. Single with Tags/Categories.
  2. Select the Post Terms block and within the Settings sidebar, try out the text decoration support.
  3. Navigate to Global Styles > Blocks > Post Terms > Typography
  4. Try applying a new font family to Post Terms and confirm it's correctly applied in the preview and frontend.

Screenshots or screencast

Screen.Recording.2022-08-18.at.11.35.55.am.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Post Terms Affects the Post Terms Block [Feature] Typography Font and typography-related issues and PRs labels Aug 18, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 18, 2022
@aaronrobertshaw aaronrobertshaw mentioned this pull request Aug 18, 2022
Open
6 tasks
@aaronrobertshaw aaronrobertshaw force-pushed the add/missing-typography-supports-to-post-terms branch from 503befb to 6cc795e Compare August 18, 2022 01:54
@carolinan carolinan merged commit 7c3d5fb into trunk Aug 18, 2022
@carolinan carolinan deleted the add/missing-typography-supports-to-post-terms branch August 18, 2022 08:22
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 18, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carolinan carolinan carolinan approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Block] Post Terms Affects the Post Terms Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronrobertshaw @carolinan @femkreations