Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preformatted: Add missing typography supports #43345

Merged
merged 1 commit into from
Aug 18, 2022
Merged

Preformatted: Add missing typography supports #43345

merged 1 commit into from
Aug 18, 2022

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing typography supports to the Preformatted block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing font-family, text-decoration typography support.

Testing Instructions

  1. Edit a post, add a Preformatted block, and select it.
  2. Check that the font-family & text-decoration controls are now available.
  3. Test various typography settings ensuring styles are applied in the editor.
  4. Save and confirm the application on the frontend.
  5. Switch to the site editor, selecting a template with the Preformatted block.
  6. Navigate to Global Styles > Blocks > Preformatted > Typography
  7. Test applying a new font-family and confirm its applied in the preview and on the frontend.

Screenshots or screencast

Screen.Recording.2022-08-18.at.12.03.05.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Preformatted Affects the Preformatted Block - used for showing preformatted text [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Aug 18, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 18, 2022
@aaronrobertshaw aaronrobertshaw mentioned this pull request Aug 18, 2022
Open
6 tasks
talldan
talldan approved these changes Aug 18, 2022
View reviewed changes
Copy link
Contributor

@talldan talldan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well.

The only feedback from testing is whether font family should be limited to monospaced fonts for this particular block, but it also seems fine to leave this up to the user.

@aaronrobertshaw aaronrobertshaw merged commit 5317e61 into trunk Aug 18, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/missing-typography-supports-to-preformatted branch August 18, 2022 03:51
@github-actions github-actions bot added this to the Gutenberg 14.0 milestone Aug 18, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@talldan talldan talldan approved these changes

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

Assignees

@aaronrobertshaw aaronrobertshaw

Labels
[Block] Preformatted Affects the Preformatted Block - used for showing preformatted text [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 14.0
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronrobertshaw @talldan @femkreations