Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query Pagination Numbers: Add missing typography supports #43559

Conversation

aaronrobertshaw
Copy link
Contributor

Related:

What?

Adds missing typography supports to the Query Pagination Numbers block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing font-family, text-decoration typography support.

Testing Instructions

  1. Edit a post, add a Query block, and select the Query Pagination Numbers block within it.
  2. Check that the font-family & text-decoration controls are now available.
  3. Test various typography settings ensuring styles are applied in the editor.
  4. Save and confirm the application on the frontend.
  5. Switch to the site editor, add a new Query block to the template.
  6. Navigate to Global Styles > Blocks > Page Numbers > Typography (first "Page Numbers" in Blocks, name conflict will be addressed separately)
  7. Test applying a new font-family and confirm its applied in the preview and on the frontend.
  8. Test styling via theme.json

Example theme.json snippet:

			"core/query-pagination-numbers": {
				"typography": {
					"textDecoration": "line-through"
				}
			}

Screenshots or screencast

Screen.Recording.2022-08-24.at.6.49.08.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Feature] Typography Font and typography-related issues and PRs labels Aug 24, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 24, 2022
@glendaviesnz
Copy link
Contributor

This mostly tests ok for me, except if I set the font family in the blocks section of global styles, if I do so the selected font is not shown in the editor and the front end, but if I set the Post Title block font size in global styles -> blocks the change is reflected in the editor and front end.

@glendaviesnz
Copy link
Contributor

This mostly tests ok for me, except if I set the font family in the blocks section of global styles, if I do so the selected font is not shown in the editor and the front end, but if I set the Post Title block font size in global styles -> blocks the change is reflected in the editor and front end.

Actually, ignore that, working now after a full refresh.

Copy link
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:
Can set font family and decoration in post editor and reflected in front end
Can set from family in global styles and reflected in editor and front end
Changes to theme.json also applied

@aaronrobertshaw aaronrobertshaw force-pushed the add/missing-typography-supports-to-query-pagination-numbers branch from 210393d to da116b9 Compare August 26, 2022 08:15
@aaronrobertshaw aaronrobertshaw merged commit 75add8d into trunk Aug 26, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/missing-typography-supports-to-query-pagination-numbers branch August 26, 2022 09:15
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Aug 26, 2022
@femkreations femkreations added Needs User Documentation Needs new user documentation and removed Needs User Documentation Needs new user documentation labels Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Query Pagination Affects the Query Pagination Block - used for pagination within the Query Loop Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants