Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quote: Add missing typography supports #43567

Merged

Conversation

aaronrobertshaw
Copy link
Contributor

@aaronrobertshaw aaronrobertshaw commented Aug 24, 2022

Related:

What?

Adds missing typography supports to the Quote block.

Why?

  • Improves consistency of our design tools across blocks.

How?

  • Opts into missing font-family, text-decoration typography support.

Testing Instructions

  1. Edit a post, add a Quote block, and select it.
  2. Check that the font family & text-decoration controls are now available.
  3. Test various typography settings ensuring styles are applied in the editor.
  4. Save and confirm the application on the frontend.
  5. Switch to the site editor, and add a new Quote block to the template.
  6. Navigate to Global Styles > Blocks > Quote > Typography
  7. Test applying a new font family and confirm it's applied in the preview and on the frontend.
  8. Test styling via theme.json

Example theme.json snippet:

			"core/quote": {
				"typography": {
					"textDecoration": "line-through"
				}
			}

Screenshots or screencast

Screen.Recording.2022-08-24.at.7.06.35.pm.mp4

@aaronrobertshaw aaronrobertshaw added [Type] Enhancement A suggestion for improvement. [Block] Quote Affects the Quote Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs labels Aug 24, 2022
@aaronrobertshaw aaronrobertshaw self-assigned this Aug 24, 2022
Copy link
Contributor

@glendaviesnz glendaviesnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, font family and decoration worked as expected in:

✅ Post editor and frontend
✅ Site editor and fronten
✅ Font family worked in global styles block settings
✅ Theme.json

@aaronrobertshaw aaronrobertshaw force-pushed the add/missing-typography-supports-to-quote-block branch from ad09f50 to 94f797d Compare August 26, 2022 08:51
@aaronrobertshaw aaronrobertshaw merged commit ba34638 into trunk Aug 26, 2022
@aaronrobertshaw aaronrobertshaw deleted the add/missing-typography-supports-to-quote-block branch August 26, 2022 11:01
@github-actions github-actions bot added this to the Gutenberg 14.1 milestone Aug 26, 2022
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Sep 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Quote Affects the Quote Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Feature] Typography Font and typography-related issues and PRs Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants