Lodash: Remove completely from @wordpress/format-library package
#43738
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Performance
tyxla
requested review from
antonis,
aristath,
gziolo,
swissspidy,
geriux,
jorgefilipecosta,
chad1008,
ntsekouras and
fabiankaegy
aristath
approved these changes
Aug 31, 2022
|
Size Change: +2.5 kB (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
Thanks, @aristath! I'll hold off merging until the React Native folks to confirm this isn't breaking anything on mobile. |
tyxla
force-pushed
the
remove/lodash-format-library
branch
from
58fd841
to
6d7aafa
Compare
dcalhoun
requested changes
Sep 1, 2022
Co-authored-by: David Calhoun <[email protected]>
|
Feedback has been addressed - could I get one last look, @dcalhoun? |
|
Thank you, @dcalhoun 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR removes all of the Lodash from the
@wordpress/format-librarypackage, including thelodashdependency altogether. There are just a few usages and conversion is pretty straightforward.Why?
Lodash is known to unnecessarily inflate the bundle size of packages, and in most cases, it can be replaced with native language functionality. See these for more information and rationale:
@wordpress/api-fetchpackage haslodashas a dependency #39495How?
We're replacing a few usages with their native counterparts.
Testing Instructions