Components: Refactor ColorPalette tests to @testing-library/react
#44108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyxla
added
[Type] Enhancement
tyxla
requested review from
Mamaduka,
mirka,
gziolo,
ciampo,
jorgefilipecosta,
chad1008 and
ntsekouras
tyxla
force-pushed
the
refactor/color-palette-tests-rtl
branch
from
2572596
to
ec15b93
Compare
|
Size Change: -119 B (0%) Total Size: 1.25 MB
ℹ️ View Unchanged
|
ciampo
reviewed
Sep 13, 2022
|
|
||
| test( 'should call onToggle on click.', () => { | ||
| renderedToggleButton.find( 'button' ).simulate( 'click' ); | ||
| await user.click( |
There was a problem hiding this comment.
Should we add a spy for the onToggle callback prop and make sure that .toHaveBeenCalledTimes( 1 ), like in the original test?
There was a problem hiding this comment.
Hm, how would you recommend this to happen without modifications to the original component?
There was a problem hiding this comment.
My bad, I didn't realize that the Dropdown component is an implementation detail, internal to ColorPalette and therefore it's not possible to pass a spy for onToggle 😅
ciampo
approved these changes
Sep 14, 2022
|
|
||
| test( 'should call onToggle on click.', () => { | ||
| renderedToggleButton.find( 'button' ).simulate( 'click' ); | ||
| await user.click( |
There was a problem hiding this comment.
My bad, I didn't realize that the Dropdown component is an implementation detail, internal to ColorPalette and therefore it's not possible to pass a spy for onToggle 😅
Mamaduka
pushed a commit
that referenced
this pull request
Nov 10, 2022
Mamaduka
pushed a commit
that referenced
this pull request
Nov 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
We've recently started refactoring
enzymetests to@testing-library/react.This PR refactors the
ColorPalettetests fromenzymeto@testing-library/react.Why?
@testing-library/reactprovides a better way to write tests for accessible components that is closer to the way the user experiences them.How?
We're straightforwardly replacing
enzymetests with@testing-library/reactones, usingjest-dommatchers and mocks to avoid testing unrelated implementation details.Ideally, we should not be using snapshot tests here, however, the purpose of this PR is not to improve or enrich the tests themselves, but rather to migrate them
@testing-library/react. Our primary motivation is unblocking the upgrade to React 18.In any case, it would be a good future step to improve the tests and test actual experience and interaction in order to improve the overall value of the tests.
Testing Instructions
Verify tests pass:
npm run test:unit packages/components/src/color-palette/test/index.js