Site Title: Avoid 403 errors for users with low permissions #45093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Mamaduka
added
[Type] Bug
Mamaduka
requested review from
ntsekouras and
ockham
and removed request for
ntwb,
ajitbohra and
nerrad
|
Size Change: +619 B (0%) Total Size: 1.28 MB
ℹ️ View Unchanged
|
|
Can anyone confirm if the newly enabled e2e test is passing locally for them? |
ntsekouras
reviewed
Oct 20, 2022
There was a problem hiding this comment.
Thanks George! The test is passing locally for me..
I'm wondering if it has something to do with the changes when the actual title is fetched and the nodes. Have you tried something like waiting for the node with the site title inside and then check the prop?
And a small nit: in the new test the variable name shouldn't be editableSiteTitleSelector.
|
I adjusted the e2e tests a bit. Let's see if this works. The CI test logs also show 400 requests; maybe the failure is related to user swapping. |
|
I think we also have a different cause of flakiness for the site title tests. So I'm going to revert the e2e tests state and only merge the 403 error bug fix. |
ntsekouras
approved these changes
Oct 20, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #33003.
PR fixes
403errors generated by the Site Title block for non-admin users.Why?
The editor should check permission before making requests when data isn't available for everyone.
How?
I've updated the selector logic to conditionally use (and fetch) data from the settings endpoint or from the read-only index based on user permissions.
Testing Instructions
Admin users
The Site Title block should work as before.
Non-admin users (e.g. Editor or Author role).
E2E Tests