Perf Tests: Stop building project types during test build phase #45284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.3 MB ℹ️ View Unchanged
|
dmsnell
force-pushed
the
tests/stop-building-types-during-perf-tests
branch
2 times, most recently
from
e95bf5b
to
67a2399
Compare
dmsnell
force-pushed
the
tests/stop-building-types-during-perf-tests
branch
3 times, most recently
from
1561697
to
a1920fa
Compare
dmsnell
force-pushed
the
tests/stop-building-types-during-perf-tests
branch
from
a1920fa
to
958c66d
Compare
georgeh
approved these changes
Nov 17, 2022
We don't use the types we build during the test runs, but generating them performs additional wasted work. Let's skip over that step to cut out unecessary delay and to avoid computation we don't need.
dmsnell
force-pushed
the
tests/stop-building-types-during-perf-tests
branch
from
958c66d
to
8e83fff
Compare
dmsnell
added a commit
that referenced
this pull request
Nov 20, 2022
In #45284 we started skipping the generate-types phase of the build when running the performance tests. This was done to avoid the time it takes to generate those types when they are ignored by the rest of the test suite. In that patch we accidentally skipped running `wp-scripts build`, and in this patch we're bringing that back to fix the mistake.
dmsnell
added a commit
that referenced
this pull request
Nov 21, 2022
In #45284 we started skipping the generate-types phase of the build when running the performance tests. This was done to avoid the time it takes to generate those types when they are ignored by the rest of the test suite. In that patch we accidentally skipped running `wp-scripts build`, and in this patch we're bringing that back to fix the mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Skips TypeScript types generation during performance test runs.
Why?
We don't use the types we build during the performance test runs, but generating them slows down the tests by doing more things.
How?
By not doing more things we should take less time to finish running the test workflow.
Testing Instructions
Given that this change only affects the types generated during the performance test workflow things ought to be sound as long as the performance test suite passes.
Please audit the code to review the change and comment on it if you find any concerns.
The tradeoff in this PR is that we're using
node ./bin/packages/build.jsdirectly instead of callingnpm run build. We could create a separatenpmscript to build without runningnpm run build:package-typesbut I suspect that this is one of the few cases we want this change. We could get out of date withpackage.json, but also I think if something important were to impact the tests they would start failing and we could investigate.