-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Universal block inspector controls back button #46058
Conversation
Open in CodeSandbox Web Editor | VS Code | VS Code Insiders |
Size Change: +35 B (0%) Total Size: 1.31 MB
ℹ️ View Unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@getdave This looks reasonable to me. One blocker below.
onClick={ () => | ||
selectBlock( closestControllingBlock?.clientId ) | ||
} | ||
label={ __( 'Go to controlling block' ) } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make this label more explanatory. Example: label={ sprintf( __( 'Back to parent block: %s', parentBlock.title ) ) }
closestControllingBlock?.name !== 'core/template-part' && | ||
closestControllingBlock?.name !== 'core/block'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These values could come from block editor settings?
I'm not sure this PR is needed anymore so I"m closing it out. |
What?
In #46037 (comment) we modified the back button in the inspextor controls so that it selects the closest parent Navigatino block.
This PR tries to make that solution universal to all block types outside of the experiment by seeking the first parent block that is controlling inner blocks and selecting that.
Why?
How?
Testing Instructions
Screenshots or screencast