Update performance tests to work with themes that load editor into an iframe #46665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noisysocks
added
the
[Type] Automated Testing
|
Size Change: 0 B Total Size: 1.32 MB ℹ️ View Unchanged
|
noisysocks
commented
Dec 20, 2022
| await page.waitForSelector( '.edit-post-layout', { | ||
| timeout: 120000, | ||
| } ); | ||
| await canvas().waitForSelector( '.wp-block', { timeout: 120000 } ); |
There was a problem hiding this comment.
Copied this approach from the site editor performance tests:
gutenberg/packages/e2e-tests/specs/performance/site-editor.test.js
Lines 94 to 97 in b1234a7
Not sure if the large timeout is necessary. Should be harmless though.
There was a problem hiding this comment.
personally I've raised questions about them too and I think we'd benefit but cutting out earlier. in cases like these we have to wait two extra minutes before calling it a failure, but the threshold is far earlier than two minutes where we know something went wrong.
|
Cool that seems to work! |
|
Will merge this so that we can unblock everyone's PRs 🙂 |
|
LGTM |
|
cc: @ellatrix |
|
Thanks noisysocks! Not sure why it didn't fail. Maybe @youknowriad knows more. |
|
nop, that's a mystery for me too |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully fixes the Run performance tests GitHub action which is currently failing on every PR.
Working out why the actions is failing by looking at the logs is a bit confusing because the performance tests run differently depending on the branch, what's in
trunka the time of run, etc.Instead I ignored all of that and ran
npm run test:performancelocally which output a few errors to do with using selectors that will no longer work as of #46212 because the block editor is now loaded into an iframe.The two big mysteries in my mind are:
trunkcommit?Anyway with these changes
npm run test:performanceand./bin/plugin/cli.js perfwork for me on my local machine. Let's see what GitHub thinks.