Iframe: simplify/reactify compat styles logic #46732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: +20 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
ellatrix
force-pushed
the
try/iframe-simplify-compat-styles
branch
from
c116c90
to
a97ae46
Compare
youknowriad
reviewed
Dec 22, 2022
| @@ -205,6 +115,11 @@ function Iframe( | |||
| const [ iframeDocument, setIframeDocument ] = useState(); | |||
| const [ bodyClasses, setBodyClasses ] = useState( [] ); | |||
| const styles = useParsedAssets( assets?.styles ); | |||
| const styleIds = styles.map( ( style ) => style.id ); | |||
| const compatStyles = useCompatibilityStyles( styles ); | |||
There was a problem hiding this comment.
It seems the argument is useless here right?
youknowriad
approved these changes
Dec 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
In #40842 the compat styles were moved after the properly enqueued styles, while they used to be before those styles.
Currently compat styles are added in an uncontrolled way outside React. This PR changes it so we memoize the compat styles and then merge it with the rest of the styles to be added in a controlled way by React.
This allows us to remove the hidden div in the body and move them back to head.
Also moves the whole hook to a separate file.
Why?
Clean up
How?
Testing Instructions
We have e2e tests, nothing should fail.
Testing Instructions for Keyboard
Screenshots or screencast