Update the script registration of the react scripts with a cache version #46768
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
youknowriad
added
the
[Type] Bug
mcsf
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #46737
What?
We did an update to React in the previous Gutenberg release 14.8 but it seems the script url didn't change, the version that is used for the script is the WP version which remains stable between two gutenberg versions. This PR forces the use of the React version for this script as a short term fix.
Long term, we should try to use the version from the package.json file somehow.
Testing Instructions
1- Clear browse cache
2- Use a Gutenberg version prior to 14.7 (or 14.7)
3- Load the editor
4- Update the Gutenberg version to 14.8 (or this PR)
5- If you try to save the post, you'll have an error in 14.8 but it should work with this PR.