Alternative Nav Offcanvas show link UI for submenu creation #46857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
getdave
commented
Jan 3, 2023
getdave
commented
Jan 3, 2023
packages/block-editor/src/components/off-canvas-editor/block.js
Outdated
Show resolved
Hide resolved
|
Size Change: -3 B (0%) Total Size: 1.32 MB
ℹ️ View Unchanged
|
getdave
requested review from
scruffian,
MaggieCabrera,
ajlende and
draganescu
getdave
added
[Block] Navigation
scruffian
previously approved these changes
Jan 4, 2023
|
The next thing to explore would be to use the normal block inserter when another block exists in the navigation, like we do with the main block inserter in the navigation block in this case:
|
I can handle that 👍 Update: here is a PR for that #46898 |
|
This one will be rebased once #46885 lands. We can then utilise the new selector and look to land this feature. |
getdave
force-pushed
the
try/offcanvas-show-link-ui-for-submenu-creation-alt
branch
from
2603131
to
8df4b1c
Compare
getdave
dismissed
scruffian’s stale review
The code has changed a fair bit and it's worth re-testing now.
draganescu
approved these changes
Jan 5, 2023
getdave
deleted the
try/offcanvas-show-link-ui-for-submenu-creation-alt
branch
82 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Alternative approach to #46582.
Shows the Link UI in the Nav Offcanvas when creating a submenu.
Why?
Currently it's not possible to get the full link creation experience when creating submenus in the offcanvas.
How?
Builds on research and foundations of #46582 and the work in #46744 to simplify the task of showing the Link UI when creating submenus.
Currently on
trunkthe feature already works with one exception which I have previously detailed which concerns creating submenus from nav items which are not currently submenus.Instead of using a single
replaceBlockscall and providing the new custom link as inner blocks in that single call we now split this process into two stagesWith the changes to the reducer which tracks the last "inserted" block clientId the
getLastInsertedBlockClientIdreturns correctly for the problem scenario previously described.As a result you now see the Link UI regardless of whether you created a submenu from an existing submenu or from a standard custom link
Testing Instructions
Add submenu item.Add submenu item.Testing Instructions for Keyboard
Screenshots or screencast
Screen.Capture.on.2023-01-05.at.13-47-42.mp4