Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor Button component to TypeScript #46997

Merged
merged 46 commits into from
Jan 24, 2023
Merged

Refactor Button component to TypeScript #46997

merged 46 commits into from
Jan 24, 2023

Commits on Jan 3, 2023

  1. Rename button/index.js to .jsx

    @kienstra
    kienstra committed Jan 3, 2023
    Configuration menu
    Copy the full SHA
    c05948f View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2023

  1. Possible approach to the prop types

    @kienstra
    kienstra committed Jan 5, 2023
    Configuration menu
    Copy the full SHA
    5b57ef6 View commit details
    Browse the repository at this point in the history

Commits on Jan 9, 2023

  1. Simplify the tag container

    @kienstra
    kienstra committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    718959c View commit details
    Browse the repository at this point in the history

  2. Allow passing childrent to TagElement

    @kienstra
    kienstra committed Jan 9, 2023
    Configuration menu
    Copy the full SHA
    d8cae0c View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2023

  1. Fix the type of onKeyDown

    @kienstra
    kienstra committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    d007837 View commit details
    Browse the repository at this point in the history

  2. Rename test/index.js to .tsx, fix some errors

    @kienstra
    kienstra committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    6ab8806 View commit details
    Browse the repository at this point in the history

  3. Fix an eslint error from children being defined in the outer scope

    @kienstra
    kienstra committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    878c77d View commit details
    Browse the repository at this point in the history

  4. Rename stories/index.js to .tsx, add type annotations

    @kienstra
    kienstra committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    78e0aaf View commit details
    Browse the repository at this point in the history

  5. Merge branch 'trunk' into update/button-ts

    @kienstra
    kienstra committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    00c05da View commit details
    Browse the repository at this point in the history

  6. Alphabetize types.ts types

    @kienstra
    kienstra committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    9e6cc7d View commit details
    Browse the repository at this point in the history

  7. Refactor TagElement to element

    @kienstra
    kienstra committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    9298bd7 View commit details
    Browse the repository at this point in the history

  8. Alphabetize an import

    @kienstra
    kienstra committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    7314d0a View commit details
    Browse the repository at this point in the history

  9. Revert changes to element, this will fail type checking

    @kienstra
    kienstra committed Jan 10, 2023
    Configuration menu
    Copy the full SHA
    0b616c7 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2023

  1. Merge branch 'trunk' into update/button-ts

    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    3998f8b View commit details
    Browse the repository at this point in the history

  2. Use the [] array type syntax

    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    67efafe View commit details
    Browse the repository at this point in the history

  3. Improve the typing of hasChildren

    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    bbc7cd4 View commit details
    Browse the repository at this point in the history

  4. Fix the typing of chilren.length

    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    0f7a242 View commit details
    Browse the repository at this point in the history

  5. Revert "Revert changes to element, this will fail type checking" 

    This reverts commit 0b616c7.
    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    ca6ded1 View commit details
    Browse the repository at this point in the history

  6. Pass the generic of WordPressComponentProps a second argument

    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    dadbb4b View commit details
    Browse the repository at this point in the history

  7. Don't destructure out children, simply let them be in props

    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    a447deb View commit details
    Browse the repository at this point in the history

  8. Use React.MousEvent

    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    e702dd4 View commit details
    Browse the repository at this point in the history

  9. Update README.md with types from types.ts

    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    0badec8 View commit details
    Browse the repository at this point in the history

  10. Fix the type of shortcut

    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    b9a3b50 View commit details
    Browse the repository at this point in the history

  11. Remove unnecessary Type annotations

    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    57866b7 View commit details
    Browse the repository at this point in the history

  12. In README.md, alphabetize the props

    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    d8dcaee View commit details
    Browse the repository at this point in the history

  13. Add a Required annotation to the variant prop

    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    5e270a1 View commit details
    Browse the repository at this point in the history

  14. Add a JS DocBlock to Button

    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    8ce4937 View commit details
    Browse the repository at this point in the history

  15. Add a CHANGELOG entry

    @kienstra
    kienstra committed Jan 15, 2023
    Configuration menu
    Copy the full SHA
    fd4144a View commit details
    Browse the repository at this point in the history

Commits on Jan 21, 2023

  1. Commit Lena's suggestion: Update packages/components/src/button/types.ts 

    Co-authored-by: Lena Morita <[email protected]>
    @kienstra @mirka
    kienstra and mirka authored Jan 21, 2023
    Configuration menu
    Copy the full SHA
    916f9ac View commit details
    Browse the repository at this point in the history

  2. Commit Lena's suggestion: Update packages/components/src/button/depre… 

    …cated.tsx

Co-authored-by: Lena Morita <[email protected]>
    @kienstra @mirka
    kienstra and mirka authored Jan 21, 2023
    Configuration menu
    Copy the full SHA
    3632a42 View commit details
    Browse the repository at this point in the history

  3. Commit Lena's suggestion: Update packages/components/src/button/index… 

    ….tsx

Co-authored-by: Lena Morita <[email protected]>
    @kienstra @mirka
    kienstra and mirka authored Jan 21, 2023
    Configuration menu
    Copy the full SHA
    309db5c View commit details
    Browse the repository at this point in the history

Commits on Jan 22, 2023

  1. Apply Lena's suggestion to change 'div' to 'button' 

    Also, correct some typing errors.
    @kienstra
    kienstra committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    31cbdab View commit details
    Browse the repository at this point in the history

  2. Remvoe needless type DisabledEvent

    @kienstra
    kienstra committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    2ca61e5 View commit details
    Browse the repository at this point in the history

  3. Remove needless argTypes that Storybook will infer from types

    @kienstra
    kienstra committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    be1359d View commit details
    Browse the repository at this point in the history

  4. Restore a deleted test, thanks to Lena's idea 

    As Lena mentioned, the intent of this test looks like
ensuring that additional props are passed to the element.
    @kienstra
    kienstra committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    35f8efb View commit details
    Browse the repository at this point in the history

  5. Don't expect the console to error

    @kienstra
    kienstra committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    b84337d View commit details
    Browse the repository at this point in the history

  6. Update tooltipPosition in README.md

    @kienstra
    kienstra committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    14e1137 View commit details
    Browse the repository at this point in the history

  7. Merge branch 'trunk' into update/button-ts

    @kienstra
    kienstra committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    12fa70f View commit details
    Browse the repository at this point in the history

  8. Move the CHANGELOG entry to Unreleased

    @kienstra
    kienstra committed Jan 22, 2023
    Configuration menu
    Copy the full SHA
    a38c275 View commit details
    Browse the repository at this point in the history

Commits on Jan 23, 2023

  1. Cherry-pick @mirka 's commit to make Button types specific to a or bu… 

    …tton
    @kienstra
    kienstra committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    cea1f6b View commit details
    Browse the repository at this point in the history

  2. Commit Lena's static tests verbatim 

    #46997 (review)
    @kienstra
    kienstra committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    ccd87bc View commit details
    Browse the repository at this point in the history

  3. Fix a failed test run that I caused

    @kienstra
    kienstra committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    561d6aa View commit details
    Browse the repository at this point in the history

  4. Rename CommonButtonProps to BaseButtonProps

    @kienstra
    kienstra committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    3892543 View commit details
    Browse the repository at this point in the history

  5. Merge in trunk, resolve conflict

    @kienstra
    kienstra committed Jan 23, 2023
    Configuration menu
    Copy the full SHA
    01f3c9c View commit details
    Browse the repository at this point in the history

  6. Commit Lena's suggestion: Update packages/components/src/button/stori… 

    …es/index.tsx

Co-authored-by: Lena Morita <[email protected]>
    @kienstra @mirka
    kienstra and mirka authored Jan 23, 2023
    Configuration menu
    Copy the full SHA
    07b7002 View commit details
    Browse the repository at this point in the history

Commits on Jan 24, 2023

  1. Commit Lena's diff for static typing test

    @kienstra
    kienstra committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    dfef117 View commit details
    Browse the repository at this point in the history