Refactor Toolbar component to TypeScript

[mike-day]

Part of #35744

What?

Convert the Toolbar component to TypeScript.

Why?

As a contribution to the ongoing effort to convert @WordPress/components to TypeScript.

How?

By adding types to Toolbar, @ts-nocheck where needed for related Toolbar components, and refactoring of stories.

Testing Instructions

1. Create or otherwise open a post
2. Add a block that would have some toolbar controls (e.g. Image)
3. Expected: The toolbar should fundamentally work the same as before:

[github-actions]

👋 Thanks for your first Pull Request and for helping build the future of Gutenberg and WordPress, @mike-day! In case you missed it, we'd love to have you join us in our Slack community, where we hold regularly weekly meetings open to anyone to coordinate with each other.

If you want to learn more about WordPress development in general, check out the Core Handbook full of helpful information.

[ciampo]

Hey @mike-day , thank you so much for starting the work on this!

I will try to come back with a proper review later, but for now I just wanted to say that there will be some conflicts with PR #47117 — I would recommend you wait until that's merged (hopefully within 1-2 days) and then rebase your PR on top of latest trunk. There will be some conflicts on the Storybook files but they should be minor :)

[mike-day]

Hey @mike-day , thank you so much for starting the work on this!

I will try to come back with a proper review later, but for now I just wanted to say that there will be some conflicts with PR #47117 — I would recommend you wait until that's merged (hopefully within 1-2 days) and then rebase your PR on top of latest trunk. There will be some conflicts on the Storybook files but they should be minor :)

Thanks for following up about this so quickly, @ciampo! I see that #47117 is merged, and I should be able to rebase and resolve conflicts within the next few days.

I will mark this as ready for review and ping you again soon!

[mike-day]

Regardless of a few failing mobile tests, I believe this PR is at a decent starting point if you want to take a look, @ciampo. Thanks!

[mirka]

Thanks for contributing! 🙌 Good call to keep the scope of this PR to a manageable size.

I just had a few comments, but on the whole this looks clean and pretty close to merging!

[ciampo]

Nitty, but should we add the toolbar subfolders that are not typed yet here, instead of @ts-ignore at the top of the files?

[mirka]

If they're not going to be typed in the next week or so, I think I prefer the ts-nochecks so we can clear out this exclude list and ship the package types 🙈

[ciampo]

Ah, I see! But wouldn't it be weird to ship partial types for Toolbar?

[mike-day]

Fwiw, I am starting work on toolbar-button today with a general plan to run through the remaining toolbar subfolders this month 💻

[mirka]

Looks great, thank you! We can merge once the changelog is tweaked 🚀