New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make `Button` component types specific to `<a>` and `<button>` #47339

Closed

kienstra wants to merge 2 commits into update/button-ts from update/specific-button-ts

Contributor

kienstra commented Jan 23, 2023

Not ready for review

A follow up to Refactor Button component to TypeScript #46997
Makes the <Button> types specific to whether the button is a <a> or <button>

kienstra added 2 commits

January 22, 2023 00:46


          Make the types specific to <a> and <button>

afba83e


          Fix failed unit tests (though type errors remain)

604fb45

kienstra closed this

kienstra deleted the update/specific-button-ts branch

January 23, 2023 03:57

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet