Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Block Library - Site Tagline]: Add example in block settings #48326

Closed
wants to merge 1 commit into from

Conversation

ntsekouras
Copy link
Contributor

What?

Just adds an example in Site Tagline's settings, so it can have a preview and be shown in Style book.

@ntsekouras ntsekouras added [Type] Bug An existing feature does not function as intended [Package] Block library /packages/block-library [Block] Site Tagline Affects the Site Tagline Block labels Feb 22, 2023
@ntsekouras ntsekouras self-assigned this Feb 22, 2023
@github-actions
Copy link

Flaky tests detected in 4c410bc.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4244436190
📝 Reported issues:

@ntsekouras ntsekouras added the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 22, 2023
@andrewserong
Copy link
Contributor

Apologies @ntsekouras it looks like I merged my PR that does the same over in #48300 (I added a placeholder attribute so that empty Site taglines don't show "Write a site tagline", so had to put the change in the index.js instead of block.json so that the string could be translated).

@ntsekouras ntsekouras closed this Feb 23, 2023
@ntsekouras ntsekouras removed the Backport to WP 6.7 Beta/RC Pull request that needs to be backported to the WordPress major release that's currently in beta label Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Site Tagline Affects the Site Tagline Block [Package] Block library /packages/block-library [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants