SpacingSizesControl: Fix white dot on thumb #48574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: -31 B (0%) Total Size: 1.33 MB
ℹ️ View Unchanged
|
t-hamano
added
[Type] Build Tooling
glendaviesnz
added
the
Backport to WP 6.7 Beta/RC
|
This tested well for me. @mirka, @ciampo although we are trying to avoid these fixed classnames in components, but for this component we already have If we need to avoid adding this classname we could instead use: .components-range-control__wrapper.is-marked > :nth-last-child(2) {
z-index: 3;
}but that seems just as flakey, and not as easy to track down this mod as a search for a classname. What do you think? |
Yes, unsanctioned style overrides are fragile no matter what the implementation is. I agree that a classname is the lesser of all evils because they're at least searchable 👍 |
|
Thank you for the review, @glendaviesnz, @mirka! |
ntsekouras
pushed a commit
that referenced
this pull request
Feb 28, 2023
* SpacingSizesControl: Fix white dot on thumb * Update changelog
|
I just cherry-picked this PR to the wp/6.2 branch. |
ntsekouras
removed
the
Backport to WP 6.7 Beta/RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR fixes the white dot that appears on the handle in the
SpacingSizesControlcomponent.Why?
The following style is applied to this handle in order to place it in front of the track separator:
gutenberg/packages/block-editor/src/components/spacing-sizes-control/style.scss
Lines 129 to 131 in 3faa015
This style is applied when the Gutenberg project is running in dev mode. This is because when in dev mode, the class name will be generated automatically by the autoLabel option of
@emotion/babel-plugin. However, when bundled with the WordPress core or when the Gutenberg plugin is built, this class name is not generated and the style is not hit.How?
I applied the class name explicitly so that it would not depend on the built environment. Ideally, In the babel configuration file, I think it would be better to explicitly set the autoLabel option to
neverinstead of the defaultdev-only.Testing Instructions
spacing.Screenshots
Before
After