-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add command to run performance tests in debug mode #48614
Conversation
Size Change: 0 B Total Size: 1.33 MB ℹ️ View Unchanged
|
Flaky tests detected in 5631aa7. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4301400180
|
@@ -299,11 +299,12 @@ | |||
"test": "npm-run-all lint test:unit", | |||
"test:create-block": "bash ./bin/test-create-block.sh", | |||
"test:e2e": "wp-scripts test-e2e --config packages/e2e-tests/jest.config.js", | |||
"test:e2e:debug": "wp-scripts --inspect-brk test-e2e --config packages/e2e-tests/jest.config.js --puppeteer-devtools", | |||
"test:e2e:debug": "wp-scripts --inspect-brk test-e2e --runInBand --no-cache --verbose --config packages/e2e-tests/jest.config.js --puppeteer-devtools", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we need to explicitly pass the flag to run tests in sequence? It should always be enforced for e2e tests inside the custom script’s code.
It's correct but at the same redundant. Not a blocker though.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding the comment in the code that documents the reason for running e2e tests serially.
Thanks, @jsnajdr! |
Spinoff from the Jest upgrade PR in #47388.
test:performance:debug
command topackage.json
no-cache
,verbose
) also to the existingtest:e2e:debug
commandhasRunInBand
code in thetest-e2e.js
script, whose purpose is otherwise unclear and confusing