Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

withFocusReturn: Convert to TypeScript #48748

Merged
merged 4 commits into from
Mar 10, 2023
Merged
Show file tree
Hide file tree
Changes from 2 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
- `Guide`: Convert to TypeScript ([#47493](https://github.com/WordPress/gutenberg/pull/47493)).
- `PanelBody`: Convert to TypeScript ([#47702](https://github.com/WordPress/gutenberg/pull/47702)).
- `withFallbackStyles` HOC: Convert to TypeScript ([#48720](https://github.com/WordPress/gutenberg/pull/48720)).
- `withFocusReturn` HOC: Convert to TypeScript ([#48748](https://github.com/WordPress/gutenberg/pull/48748)).
- `navigateRegions` HOC: Convert to TypeScript ([#48632](https://github.com/WordPress/gutenberg/pull/48632)).

## 23.5.0 (2023-03-01)
Expand Down
64 changes: 0 additions & 64 deletions packages/components/src/higher-order/with-focus-return/index.js

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,74 @@
/**
* WordPress dependencies
*/
import { Component, WPComponent } from '@wordpress/element';
import { createHigherOrderComponent, useFocusReturn } from '@wordpress/compose';
import deprecated from '@wordpress/deprecated';

/**
* Returns true if the given object is component-like. An object is component-
* like if it is an instance of wp.element.Component, or is a function.
*
* @param object Object to test.
*
* @return Whether object is component-like.
*/
function isComponentLike( object: any ): object is WPComponent {
return object instanceof Component || typeof object === 'function';
}

type Props = {
onFocusReturn?: () => void;
};

/**
* Higher Order Component used to be used to wrap disposable elements like
* sidebars, modals, dropdowns. When mounting the wrapped component, we track a
* reference to the current active element so we know where to restore focus
* when the component is unmounted.
*
* @param options The component to be enhanced with
* focus return behavior, or an object
* describing the component and the
* focus return characteristics.
*
* @return Higher Order Component with the focus restauration behaviour.
*/
export default createHigherOrderComponent(
// @ts-expect-error TODO: Reconcile with intended `createHigherOrderComponent` types
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This HOC was a bit irregular and requires a bit more effort to resolve with the upstream types, so I'll suppress it for now.

( options: WPComponent | Record< string, unknown > ) => {
const HoC =
( { onFocusReturn }: Props = {} ) =>
( WrappedComponent: WPComponent ) => {
const WithFocusReturn = (
props: Record< string, unknown >
) => {
const ref = useFocusReturn( onFocusReturn );
return (
<div ref={ ref }>
<WrappedComponent { ...props } />
</div>
);
};

return WithFocusReturn;
};

if ( isComponentLike( options ) ) {
const WrappedComponent = options;
return HoC()( WrappedComponent );
}

return HoC( options );
},
'withFocusReturn'
);

export const Provider = ( { children }: { children: React.ReactNode } ) => {
deprecated( 'wp.components.FocusReturnProvider component', {
since: '5.7',
hint: 'This provider is not used anymore. You can just remove it from your codebase',
} );

return children;
};
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,9 @@ import { Component } from '@wordpress/element';
/**
* Internal dependencies
*/
import withFocusReturn from '../';
import withFocusReturn from '..';

class Test extends Component {
class Test extends Component< { className: string; focusHistory: unknown } > {
render() {
const { className, focusHistory } = this.props;
return (
Expand Down
1 change: 0 additions & 1 deletion packages/components/tsconfig.json
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,6 @@
"src/duotone-picker",
"src/gradient-picker",
"src/higher-order/with-filters",
"src/higher-order/with-focus-return",
"src/higher-order/with-notices",
"src/navigation",
"src/palette-edit"
Expand Down