Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animate the site icon element between view and edit in the site editor #48886

Merged
merged 15 commits into from
Apr 24, 2023
Merged

Animate the site icon element between view and edit in the site editor #48886

merged 15 commits into from
Apr 24, 2023
+80 −50

Commits on Apr 24, 2023

  1. Add animation to the site icon element in the header. 

    Grow to fill the square container when going into "edit"
mode and shrink back when going into "view" mode.
    @mtias
    mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    07ceb56 View commit details
    Browse the repository at this point in the history

  2. Balance W icon size and intial animation state.

    @mtias
    mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    837773a View commit details
    Browse the repository at this point in the history

  3. Simplify layout of site hub elements.

    @mtias
    mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    c0174f7 View commit details
    Browse the repository at this point in the history

  4. Adjust timings so that title fades better according to the toolbar.

    @mtias
    mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    b99e72b View commit details
    Browse the repository at this point in the history

  5. Fix site icon loading

    @youknowriad @mtias
    youknowriad authored and mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    4a60449 View commit details
    Browse the repository at this point in the history

  6. Address issue with layout animation: 

    - Resolve problem where title element would shift on initial render.
- Improve orchestration so there's no visible overlap of elements.
    @mtias
    mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    5939903 View commit details
    Browse the repository at this point in the history

  7. Set up shape fallback while loading site icon.

    @mtias
    mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    aec03c3 View commit details
    Browse the repository at this point in the history

  8. Adjust width, height, and overflow to better render the icon.

    @mtias
    mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    ba4d1cb View commit details
    Browse the repository at this point in the history

  9. Change order of zoom operations and adjust bottom border.

    @mtias
    mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    1b6169d View commit details
    Browse the repository at this point in the history

  10. Ensure we are always scaling downwards.

    @mtias
    mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    1d6bb3c View commit details
    Browse the repository at this point in the history

  11. Account for double border in the header.

    @mtias
    mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    bd495d6 View commit details
    Browse the repository at this point in the history

  12. Remove unnecessary lines.

    @mtias
    mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    98f464e View commit details
    Browse the repository at this point in the history

  13. Fix centering of W icon.

    @mtias
    mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    3ac12bd View commit details
    Browse the repository at this point in the history

  14. Revert useAnimation() as it no longer works in later versions

    @mtias
    mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    5710aaa View commit details
    Browse the repository at this point in the history

  15. Tweak button sizing & border in edit mode

    @ciampo @mtias
    ciampo authored and mtias committed Apr 24, 2023
    Configuration menu
    Copy the full SHA
    7849538 View commit details
    Browse the repository at this point in the history