i18n: Add context to labels related to CSS position properties #49135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
t-hamano
added
the
Internationalization (i18n)
|
Size Change: +389 B (0%) Total Size: 1.34 MB
ℹ️ View Unchanged
|
ocean90
reviewed
Mar 17, 2023
Co-authored-by: Dominik Schilling <[email protected]>
Co-authored-by: Dominik Schilling <[email protected]>
|
Thank you for the review, @ocean90. I have updated based on your suggestion. |
aristath
approved these changes
Mar 24, 2023
ryanwelcher
added
[Type] Enhancement
Mamaduka
added
the
Backport to WP Minor Release
|
I just cherry-picked this PR to the wp/6.2 branch to get it included in the next release: 6d1b11e |
Mamaduka
pushed a commit
that referenced
this pull request
May 8, 2023
* i18n: Add context to CSS position property labels * Update packages/block-editor/src/hooks/position.js Co-authored-by: Dominik Schilling <[email protected]> * Update packages/block-editor/src/hooks/position.js Co-authored-by: Dominik Schilling <[email protected]> --------- Co-authored-by: Dominik Schilling <[email protected]>
Mamaduka
removed
the
Backport to WP Minor Release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
This PR adds context for translation to labels (
Sticky,Fixed) related to CSS position properties of the block support.Why?
The word "sticky" has long existed in the WordPress core as translated text, meaning "place the post at the top of the post". However, in the block editor, it represents the value of the CSS position property, meaning "element position stuck while scrolling the page".
In both of these contexts, the common word "sticky" may be able to use in English, but in other languages, there may not be a word that can be used in common.
I have looked at how the word "sticky" is translated into several languages:
While there are differences in nuance in each language, they all seem to be aware of the context of the post. And I feel that these translations cannot be used as translations of "Sticky" in the CSS position property.
Therefore, I think we need to add a context for the word "Sticky" to indicate that it is a CSS property.
How?
I have added context to "Fixed" label in addition to "Sticky" label, which the position property supports.
I would like to get advice from anyone who knows if this change makes sense in languages other than my own native language, Japanese.