Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typography support to time to read block #49257

Merged
merged 1 commit into from
Mar 22, 2023
Merged

Add typography support to time to read block #49257

merged 1 commit into from
Mar 22, 2023

Conversation

talldan
Copy link
Contributor

@talldan talldan commented Mar 22, 2023 •
edited
Loading

What?

Addresses some of #48968

Why?

Similar blocks have typography options, so I think it's good to support them here too.

How?

Add the support options.

From what I can tell there isn't anything more to it, but please let me know if there is.

Testing Instructions

  1. Add a Time to Read block
  2. Change options like Font size, family, line height etc in the block inspector

Screenshots or screencast

Screen Shot 2023-03-22 at 4 42 49 pm

@talldan talldan added [Type] Enhancement A suggestion for improvement. [Block] Time to Read Affects the Time to Read Block labels Mar 22, 2023
@talldan talldan requested a review from ajitbohra as a code owner March 22, 2023 08:48
@talldan talldan self-assigned this Mar 22, 2023
@github-actions
Copy link

Flaky tests detected in f7b4e29.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/4487981160
📝 Reported issues:

t-hamano
t-hamano approved these changes Mar 22, 2023
View reviewed changes
Copy link
Contributor

@t-hamano t-hamano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 As for the default controls, I too think just the font size is fine.

@talldan talldan merged commit 1dfec0a into trunk Mar 22, 2023
@talldan talldan deleted the add/typography-support-to-time-to-read-block branch March 22, 2023 10:01
@github-actions github-actions bot added this to the Gutenberg 15.5 milestone Mar 22, 2023
@t-hamano t-hamano mentioned this pull request Mar 30, 2023
Open
6 tasks
@femkreations femkreations added the Needs User Documentation Needs new user documentation label Jun 14, 2023
@femkreations femkreations mentioned this pull request Jul 12, 2023
Open
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aristath aristath aristath approved these changes

@t-hamano t-hamano t-hamano approved these changes

@aaronrobertshaw aaronrobertshaw Awaiting requested review from aaronrobertshaw

@ajitbohra ajitbohra Awaiting requested review from ajitbohra ajitbohra is a code owner

@ryanwelcher ryanwelcher Awaiting requested review from ryanwelcher

@juanmaguitar juanmaguitar Awaiting requested review from juanmaguitar juanmaguitar is a code owner

@fabiankaegy fabiankaegy Awaiting requested review from fabiankaegy fabiankaegy is a code owner

Assignees

@talldan talldan

Labels
[Block] Time to Read Affects the Time to Read Block Needs User Documentation Needs new user documentation [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
Gutenberg 15.5
Development

Successfully merging this pull request may close these issues.
4 participants
@talldan @aristath @t-hamano @femkreations