Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image: Add lightbox using directives. #50373

Merged
merged 126 commits into from
May 24, 2023
Merged

Image: Add lightbox using directives. #50373

merged 126 commits into from
May 24, 2023

Commits on May 23, 2023

  1. Add behaviors to the core theme.json

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    bd53de2 View commit details
    Browse the repository at this point in the history

  2. Add behaviors to json schemas for theme.json

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    bd43bf6 View commit details
    Browse the repository at this point in the history

  3. Add a behaviors panel

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    e1dd737 View commit details
    Browse the repository at this point in the history

  4. Remove the changes to theme.json schema

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8b84a22 View commit details
    Browse the repository at this point in the history

  5. Add behaviors to the VALID_SETTINGS in class-wp-theme-json-gutenberg.php

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d5dbc1c View commit details
    Browse the repository at this point in the history

  6. Add the first (still broken) version of the lightbox settings

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    037d669 View commit details
    Browse the repository at this point in the history

  7. WIP: Added a SelectControl for the behaviors

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8f62d34 View commit details
    Browse the repository at this point in the history

  8. Format PHP

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    62b6217 View commit details
    Browse the repository at this point in the history

  9. Format correctly again

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    edfd7d1 View commit details
    Browse the repository at this point in the history

  10. Use the props.name when getting the behaviors

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8ee4065 View commit details
    Browse the repository at this point in the history

  11. Add initial e2e tests

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    594224b View commit details
    Browse the repository at this point in the history

  12. Update the withBehaviors description

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    fd6fe36 View commit details
    Browse the repository at this point in the history

  13. Cleaned up behaviors.js

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    da4a5ad View commit details
    Browse the repository at this point in the history

  14. Update e2e tests to check visibility

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    2958fd1 View commit details
    Browse the repository at this point in the history

  15. Update core-blocks doc with behaviors attribute

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    0a68bea View commit details
    Browse the repository at this point in the history

  16. Update fixtures with new lightbox attribute

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    fd08928 View commit details
    Browse the repository at this point in the history

  17. Add a new theme for e2e tests

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    4e03e0d View commit details
    Browse the repository at this point in the history

  18. Change theme.json to include settings.behaviors

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    92b6e6c View commit details
    Browse the repository at this point in the history

  19. Remove default behavior value from block.json

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    ffa881e View commit details
    Browse the repository at this point in the history

  20. Minor fix to the implementation

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    99c964b View commit details
    Browse the repository at this point in the history

  21. Add more e2e tests

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    7f7db2c View commit details
    Browse the repository at this point in the history

  22. Create a selector for behaviors

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    5e5ff9a View commit details
    Browse the repository at this point in the history

  23. Add a filter to load behaviors on the server from the theme.json

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    ad20b64 View commit details
    Browse the repository at this point in the history

  24. Add behaviors on the top-level in core theme.json

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d16266b View commit details
    Browse the repository at this point in the history

  25. Use the behaviors in the hooks

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    0982d9f View commit details
    Browse the repository at this point in the history

  26. Update the comment

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    0ef7b5e View commit details
    Browse the repository at this point in the history

  27. Update the comment in behaviors.js

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    e75fd87 View commit details
    Browse the repository at this point in the history

  28. Update fixtures and e2e

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    f6414f9 View commit details
    Browse the repository at this point in the history

  29. Prevent mobile test gutenberg error (temporary - not the best solution)

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    31c0623 View commit details
    Browse the repository at this point in the history

  30. Add priority on filter

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    ee3701f View commit details
    Browse the repository at this point in the history

  31. Fix php standards

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    a0ac748 View commit details
    Browse the repository at this point in the history

  32. Found a much better way to fix php tests

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    1dd6df1 View commit details
    Browse the repository at this point in the history

  33. Small refactor

    @cbravobernal
    cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    a737200 View commit details
    Browse the repository at this point in the history

  34. Add behaviors as an allowed key to BLOCK_EDITOR_SETTINGS

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    3fd9270 View commit details
    Browse the repository at this point in the history

  35. Move the behaviors to top level in the e2e test theme.json file

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    5a9748c View commit details
    Browse the repository at this point in the history

  36. Rename the behaviors setting to behaviorsUIEnabled

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    9a6b1f2 View commit details
    Browse the repository at this point in the history

  37. Change "None" to "No behaviors"

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    1c7f6d5 View commit details
    Browse the repository at this point in the history

  38. Behaviors -> behavior

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    470f74f View commit details
    Browse the repository at this point in the history

  39. Fix redundant ternary

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    bba7c2d View commit details
    Browse the repository at this point in the history

  40. Improve the JSDoc for behaviors selector

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    2cb348c View commit details
    Browse the repository at this point in the history

  41. Rename the test themes to make more sense

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    c65bc57 View commit details
    Browse the repository at this point in the history

  42. Remove definition of behaviors attribute in core/image

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    1c655f7 View commit details
    Browse the repository at this point in the history

  43. Change default value for behaviors.lightbox to false and update e2e… 

    … tests accordingly
    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    697c04f View commit details
    Browse the repository at this point in the history

  44. Change the way we get the data from theme.json and adjust e2e

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d4fd9d9 View commit details
    Browse the repository at this point in the history

  45. Capitalize behaviors' labels

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    a57d634 View commit details
    Browse the repository at this point in the history

  46. Move PHP code adding theme.json behaviors to block-editor-settings

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    234a8b6 View commit details
    Browse the repository at this point in the history

  47. Update comment

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    4bef633 View commit details
    Browse the repository at this point in the history

  48. Remove the behaviors require from load.php

    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    7aa7231 View commit details
    Browse the repository at this point in the history

  49. Revert "Update comment" 

    This reverts commit fc812bc6c04e8b3c5c7fe3450c1e39d1dd6f6f3b.
    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    1d923ab View commit details
    Browse the repository at this point in the history

  50. Revert "Move PHP code adding theme.json behaviors to `block-editor-… 

    …settings`"

This reverts commit e8d16c8bb4977d1e27b758a067066a78fc21f794.
    @michalczaplinski @cbravobernal
    michalczaplinski authored and cbravobernal committed May 23, 2023
    Configuration menu
    Copy the full SHA
    aee908a View commit details
    Browse the repository at this point in the history

  51. Remove the comment that was added previously

    @michalczaplinski
    michalczaplinski committed May 23, 2023
    Configuration menu
    Copy the full SHA
    33cb62d View commit details
    Browse the repository at this point in the history

  52. Update comments in behaviors.php

    @michalczaplinski
    michalczaplinski committed May 23, 2023
    Configuration menu
    Copy the full SHA
    55e37a3 View commit details
    Browse the repository at this point in the history

  53. Add back the require_once in load.php

    @michalczaplinski
    michalczaplinski committed May 23, 2023
    Configuration menu
    Copy the full SHA
    d4d657b View commit details
    Browse the repository at this point in the history

  54. Use settings.blocks.core/image.behaviors.lightbox

    @michalczaplinski
    michalczaplinski committed May 23, 2023
    Configuration menu
    Copy the full SHA
    8d6b0d0 View commit details
    Browse the repository at this point in the history

  55. Use behaviors.blocks.core/image.lightbox

    @michalczaplinski
    michalczaplinski committed May 23, 2023
    Configuration menu
    Copy the full SHA
    76b2a75 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2023

  1. Remove experimental setting for interactivity API

    @cbravobernal
    cbravobernal committed May 24, 2023
    Configuration menu
    Copy the full SHA
    70e51cd View commit details
    Browse the repository at this point in the history

  2. Add lightbox to image block 

    First pass at adding lightbox.

Note: Added custom implementation of Preact Portal
because the children[0] declaration in the render method
was erroneous and undefined, preventing it from working
as expected.
    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    e69833b View commit details
    Browse the repository at this point in the history

  3. Add logic for hiding lightbox on esc key press and overlay click

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    9ca2918 View commit details
    Browse the repository at this point in the history

  4. Improve styles and add note to add conditional for lightbox markup

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    dca1b36 View commit details
    Browse the repository at this point in the history

  5. Add editor UI and attribute for toggling lightbox

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    552bc3c View commit details
    Browse the repository at this point in the history

  6. Remove image translation animation and add fade instead

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    a46c35e View commit details
    Browse the repository at this point in the history

  7. Add accessibility; clean up styles; fix bug regarding ref in directives 

    Cleaned up the PHP file a bit as I implemented standard accessibility
for a lightbox.

I changed names of attributes and properties to be clearer, as well as
conslidated some CSS.

Important to note: I fixed a bug with the directives wherein 'ref'
was coming in as null due to how it was being passed in hooks.js.
    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    5bdddd5 View commit details
    Browse the repository at this point in the history

  8. Configure image to use new Interactivity API runtime included in Gute… 

    …nberg
    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    3c8a458 View commit details
    Browse the repository at this point in the history

  9. Remove viewScript from image config

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    c69f6ff View commit details
    Browse the repository at this point in the history

  10. Add Portal directive to Interactivity API runtime

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    4802229 View commit details
    Browse the repository at this point in the history

  11. Set scrim to site background color

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    e7a7a4c View commit details
    Browse the repository at this point in the history

  12. Remove extraneous image CSS declaration

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    46b95d6 View commit details
    Browse the repository at this point in the history

  13. Improve aria labeling

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    f5ee39e View commit details
    Browse the repository at this point in the history

  14. Code cleanup; simplify syntax, consolidate code

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    5cc8eae View commit details
    Browse the repository at this point in the history

  15. Refactor code, remove event listeners, consolidate logic

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7009fa1 View commit details
    Browse the repository at this point in the history

  16. Fix formatting in SCSS file

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    910706f View commit details
    Browse the repository at this point in the history

  17. Change CheckboxControl to a ToggleControl; update API docs

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    1ebe07b View commit details
    Browse the repository at this point in the history

  18. Update wp_enqueue_script to correctly add interactivity runtime

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    10cdc07 View commit details
    Browse the repository at this point in the history

  19. Fix linter errors

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    d035dc4 View commit details
    Browse the repository at this point in the history

  20. Update to use core.image namespace

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    aa267c0 View commit details
    Browse the repository at this point in the history

  21. Pause closing of lightbox slightly when using the mousewheel

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    43dfa46 View commit details
    Browse the repository at this point in the history

  22. Rename portal directive to 'wp-body' and remove unused reference

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    58b5392 View commit details
    Browse the repository at this point in the history

  23. Add internal dependencies flag; update comment

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    0d5ef70 View commit details
    Browse the repository at this point in the history

  24. Remove extraneous code

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    1c0e406 View commit details
    Browse the repository at this point in the history

  25. Fix accessibility bug due to directives being defined incorrectly

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    926d503 View commit details
    Browse the repository at this point in the history

  26. Move enableLightbox declaration in block.json

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    68685f1 View commit details
    Browse the repository at this point in the history

  27. Remove extraneous package.json declarations

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    3811186 View commit details
    Browse the repository at this point in the history

  28. Fix PHP indentation linter error

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7840dfe View commit details
    Browse the repository at this point in the history

  29. Revise package-lock.json to match trunk

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7f2cfe5 View commit details
    Browse the repository at this point in the history

  30. Fix linter errors in portals.js

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    effd389 View commit details
    Browse the repository at this point in the history

  31. Update fixtures

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    8c7adae View commit details
    Browse the repository at this point in the history

  32. Tests: Add e2e specs for Image block on the frontend

    @gziolo @artemiomorales
    gziolo authored and artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    4558d29 View commit details
    Browse the repository at this point in the history

  33. Disable lightbox by default

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    6629975 View commit details
    Browse the repository at this point in the history

  34. Add aria-role attribute to lightbox markup

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    409941e View commit details
    Browse the repository at this point in the history

  35. Add tests

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    457cbfe View commit details
    Browse the repository at this point in the history

  36. Update fixtures

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7807fdf View commit details
    Browse the repository at this point in the history

  37. Fix accessibility issues 

    1.) Changed 'aria-role' attribute to 'role'
2.) Moved lightbox close button to before modal content
3.) Remove logic for closing dialog with Tab key
4.) Move <img> outside of <button> element
5.) Add aria-labelledby attribute to dialog
    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    0141d68 View commit details
    Browse the repository at this point in the history

  38. Add focus trap

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    f8aa92f View commit details
    Browse the repository at this point in the history

  39. Label elements as 'inert' when lightbox is open

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    5558e8d View commit details
    Browse the repository at this point in the history

  40. Update import of image interactivity scripts

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    3dc3bf9 View commit details
    Browse the repository at this point in the history

  41. Fix bug where interactivity only worked with admin enabled

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    99d95f9 View commit details
    Browse the repository at this point in the history

  42. Put lightbox rendering behind experimental flag

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    53e1d47 View commit details
    Browse the repository at this point in the history

  43. Add check for query selector and update tests

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    518e94f View commit details
    Browse the repository at this point in the history

  44. Update spacing in PHP file

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    fb7af8b View commit details
    Browse the repository at this point in the history

  45. Remove tick() and modify CSS

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    ce9b0c0 View commit details
    Browse the repository at this point in the history

  46. Update config based on behaviors UI and trunk changes

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    84be707 View commit details
    Browse the repository at this point in the history

  47. Remove extraneous code

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    899b11e View commit details
    Browse the repository at this point in the history

  48. Remove extraneous code and simplify variable name

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    1ea0d58 View commit details
    Browse the repository at this point in the history

  49. Use core WordPress API for experiments flag

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    3986e35 View commit details
    Browse the repository at this point in the history

  50. Clean up declarations

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    32dc7a8 View commit details
    Browse the repository at this point in the history

  51. Fix PHP spacing

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    48a62d2 View commit details
    Browse the repository at this point in the history

  52. Remove enableLightbox

    @michalczaplinski @artemiomorales
    michalczaplinski authored and artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    ced26e1 View commit details
    Browse the repository at this point in the history

  53. Remove defaultValue from image block.json

    @michalczaplinski @artemiomorales
    michalczaplinski authored and artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    528b60a View commit details
    Browse the repository at this point in the history

  54. Update render_callback of core/image to use Behaviors UI

    @michalczaplinski @artemiomorales
    michalczaplinski authored and artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    566460c View commit details
    Browse the repository at this point in the history

  55. Fix e2e test: 

    - Remove trailing `}`
- Incorrectly assuming `"lightbox": true`
    @michalczaplinski @artemiomorales
    michalczaplinski authored and artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    5efaa21 View commit details
    Browse the repository at this point in the history

  56. Remove 'inert' declarations for now

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    77e7fb8 View commit details
    Browse the repository at this point in the history

  57. Add period to behaviors help text

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    d854c7e View commit details
    Browse the repository at this point in the history

  58. Create selector for 'role' attribute

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    6b75413 View commit details
    Browse the repository at this point in the history

  59. Update fixtures

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    330f403 View commit details
    Browse the repository at this point in the history

  60. Update comment

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    5556ad7 View commit details
    Browse the repository at this point in the history

  61. Clean up data-wp-island attribute

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    cdae7fe View commit details
    Browse the repository at this point in the history

  62. Readd mistakenly deleted line

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    9b1534d View commit details
    Browse the repository at this point in the history

  63. Improve syntax of tests

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    3b89cef View commit details
    Browse the repository at this point in the history

  64. Replace getByLabel() with getByRole() in some tests

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    e532fb1 View commit details
    Browse the repository at this point in the history

  65. Remove 'experiments' flag

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    cd0c9dd View commit details
    Browse the repository at this point in the history

  66. Remove dependency on 'experiments' flag in tests

    @artemiomorales
    artemiomorales committed May 24, 2023
    Configuration menu
    Copy the full SHA
    429ebbe View commit details
    Browse the repository at this point in the history

  67. Revert "Remove dependency on 'experiments' flag in tests" 

    This reverts commit 429ebbe.
    @SantosGuillamot
    SantosGuillamot committed May 24, 2023
    Configuration menu
    Copy the full SHA
    95a89f7 View commit details
    Browse the repository at this point in the history

  68. Revert "Remove 'experiments' flag" 

    This reverts commit cd0c9dd.
    @SantosGuillamot
    SantosGuillamot committed May 24, 2023
    Configuration menu
    Copy the full SHA
    7c9e0eb View commit details
    Browse the repository at this point in the history

  69. Change aria-label separator

    @SantosGuillamot
    SantosGuillamot committed May 24, 2023
    Configuration menu
    Copy the full SHA
    8aebca8 View commit details
    Browse the repository at this point in the history

  70. Add back the experimental setting

    @SantosGuillamot
    SantosGuillamot committed May 24, 2023
    Configuration menu
    Copy the full SHA
    6ce95ae View commit details
    Browse the repository at this point in the history

  71. Merge branch 'trunk' into experiment/image-with-interactivity-api

    @SantosGuillamot
    SantosGuillamot authored May 24, 2023
    Configuration menu
    Copy the full SHA
    1eaffe1 View commit details
    Browse the repository at this point in the history