-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Mobile] - List block - Fix merging nested list into paragraph #50701
Conversation
…tems when merging its parent into a paragraph block
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
Flaky tests detected in 8330a75. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5024481392
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! I verified the fix on an iPhone 14 Pro simulator and Pixel 3a emulator.
Should we add a release note?
Definitely! I'll add one before merging. Thanks for the review and testing! |
# Conflicts: # packages/react-native-editor/CHANGELOG.md
Related PRs:
What?
This PR fixes an issue when merging a List Item that has sub-times into a Paragraph removes its nested blocks.
Why?
To fix an issue with the List block.
How?
By bringing the fix made for the web editor to the mobile editor as well. It also includes a fix for the undo functionality related to this block as well.
Testing Instructions
Precondition: Use the following HTML:
Testing Instructions for Keyboard
N/A
Screenshots or screencast
ListBefore.mov
ListMergeAfter.mov