Add new HeadingLevel icons
#50856
Merged
Add new HeadingLevel icons
#50856
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Size Change: 0 B Total Size: 1.4 MB ℹ️ View Unchanged
|
t-hamano
added
Needs Design Feedback
jasmussen
approved these changes
May 23, 2023
There was a problem hiding this comment.
Since this just adds the icons, which they already should have been, thanks for the PR.
Looking at this, though:
the alignemnt of icon to text doesn't seem that balanced, though, with the "Heading" text sitting a little low. It's probably best to avoid using these icons next to text in that manner, or it may be an issue with the button component.
I believe the mobile apps also use these icons, or variants thereof, so it could be good to look for any duplicates there. Thanks again!
|
@jasmussen
It's definitely a bit distracting.
Perhaps this is a font-family issue. Changing the font-family of the document to
Anyway, since this PR is not the cause, I would like to merge 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of ##50520;
Related to: #46003, #50402
What?
This PR adds the following six icons to the
iconspackage:HeadingLevel1HeadingLevel2HeadingLevel3HeadingLevel4HeadingLevel5HeadingLevel6Why?
As noted in this comment, the icons representing the heading level are used in the Heading block and the Site Title block. These icons are hard coded and not optimized for size 24.
Since these icons already exist in the Figma library, it would make sense to add this to the
iconspackage and apply it to these blocks.How?
I used this SVG data provided by @jasmussen 🙏
Testing Instructions
npm run storybook:devpackages/block-library/src/code/edit.js).Code
Related Issue/PR
In the heading block where these icons are used, there is an associated issue/PR:
Once this PR is merged, I believe that these icons can also be used in #46003 to remove the hard-coded heading icon data.
I think we need to continue to discuss the heading dropdown UI changes that are on the agenda for #50402.