Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow renaming, duplication and deleting of Navigation menus from Browse Mode Sidebar #50880

Merged
merged 31 commits into from
Jun 12, 2023
Merged

Allow renaming, duplication and deleting of Navigation menus from Browse Mode Sidebar #50880

merged 31 commits into from
Jun 12, 2023

Commits on Jun 9, 2023

  1. added more menu to navigation with delete menu option

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    93fdc55 View commit details
    Browse the repository at this point in the history

  2. modal for the rename function

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    b733e50 View commit details
    Browse the repository at this point in the history

  3. prop refactoring, title on rename popup

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    b4614b1 View commit details
    Browse the repository at this point in the history

  4. very ugly renaming of the menu

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    120bb55 View commit details
    Browse the repository at this point in the history

  5. duplicate function

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    bc52937 View commit details
    Browse the repository at this point in the history

  6. added snackbar notices to each action

    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    76b0822 View commit details
    Browse the repository at this point in the history

  7. navigate to correct places on delete and duplicate. Added Copy after … 

    …title on duplication
    @MaggieCabrera @getdave
    MaggieCabrera authored and getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    180a897 View commit details
    Browse the repository at this point in the history

  8. i18n 

    Co-authored-by: Ben Dwyer <[email protected]>
    @getdave @scruffian
    getdave and scruffian committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    884f832 View commit details
    Browse the repository at this point in the history

  9. Another i18n 

    Co-authored-by: Ben Dwyer <[email protected]>
    @getdave @scruffian
    getdave and scruffian committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    546c62e View commit details
    Browse the repository at this point in the history

  10. Apply suggestions from code review 

    Co-authored-by: Ben Dwyer <[email protected]>
    @getdave @scruffian
    getdave and scruffian committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    847c300 View commit details
    Browse the repository at this point in the history

  11. Use self documenting var name

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    e11d696 View commit details
    Browse the repository at this point in the history

  12. Use consistent confirmatory action wording

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    827cf11 View commit details
    Browse the repository at this point in the history

  13. Refactor MoreMenu to component

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    ef67830 View commit details
    Browse the repository at this point in the history

  14. Extract Modal to seperate component

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    d9609bb View commit details
    Browse the repository at this point in the history

  15. Refactor change function

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    a757dfd View commit details
    Browse the repository at this point in the history

  16. Use local state and only edit record on “save” confirmation

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    734ae9f View commit details
    Browse the repository at this point in the history

  17. Localise state closer to where it’s needed

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    49d5957 View commit details
    Browse the repository at this point in the history

  18. Disable “Save” button until menu title is modified

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    2da85f6 View commit details
    Browse the repository at this point in the history

  19. Remove file import introduced during rebase

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    58f4ef6 View commit details
    Browse the repository at this point in the history

  20. Handle Save errors

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    cb73bc6 View commit details
    Browse the repository at this point in the history

  21. Error handling for Delete action

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    efc15a5 View commit details
    Browse the repository at this point in the history

  22. Force all actions to throw on error

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    ef7bfb9 View commit details
    Browse the repository at this point in the history

  23. Add error handling for Duplicate. 

    Also pass error message and not error object.
    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    2446d46 View commit details
    Browse the repository at this point in the history

  24. Improve loading feedback when saving or deleting

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    63a98df View commit details
    Browse the repository at this point in the history

  25. Make prop naming consistent

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    97be8f1 View commit details
    Browse the repository at this point in the history

  26. i18n of modal title

    @getdave
    getdave authored Jun 9, 2023
    Configuration menu
    Copy the full SHA
    71e2af1 View commit details
    Browse the repository at this point in the history

  27. Add confirmatory step prior to delete action

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    c3d7ca9 View commit details
    Browse the repository at this point in the history

  28. Fix rename input focus border clipping

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    6bfccb3 View commit details
    Browse the repository at this point in the history

  29. Use default variant to get correct styles

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    1f60256 View commit details
    Browse the repository at this point in the history

  30. Make Copy translatable

    @getdave
    getdave committed Jun 9, 2023
    Configuration menu
    Copy the full SHA
    eac8d1c View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2023

  1. Updating confirmatory wording

    @getdave
    getdave authored Jun 12, 2023
    Configuration menu
    Copy the full SHA
    e49e2ec View commit details
    Browse the repository at this point in the history