Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Back-add changelog for TypeScript types #50881

Merged
merged 1 commit into from
May 24, 2023
Merged

Conversation

mirka
Copy link
Member

@mirka mirka commented May 23, 2023

What?

Retroactively adds a changelog entry for #49229.

Why?

I was looking for this information in the changelog and I realized it wasn't in there.

@mirka mirka added the [Package] Components /packages/components label May 23, 2023
@mirka mirka requested review from ciampo and chad1008 May 23, 2023 15:25
@mirka mirka requested a review from ajitbohra as a code owner May 23, 2023 15:25
@mirka mirka self-assigned this May 23, 2023
@github-actions
Copy link

Flaky tests detected in db249ff.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.

🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5059173855
📝 Reported issues:

@tyxla
Copy link
Member

tyxla commented May 23, 2023

I recall seeing some comments about this being a breaking change. Should we move it accordingly?

@mirka
Copy link
Member Author

mirka commented May 23, 2023

I recall seeing some comments about this being a breaking change. Should we move it accordingly?

I'm assuming we're referring to #50157 (any others?).

That is a good point, though it's kind of tricky because we can't change the semver numbers retroactively 😭 Also I think I would classify this as an enhancement with an unresolved bug, rather than an intentional breaking.

In reality, I'm guessing that it's not that important to warn consumers with a Breaking Change heading here because the disruption would be very apparent to anyone who is relying on a tsc build.

@ciampo
Copy link
Contributor

ciampo commented May 24, 2023

Also I think I would classify this as an enhancement with an unresolved bug, rather than an intentional breaking.

I also think that this in itself should not be a breaking change. It happened to cause breakage as an unintended consequence

@mirka mirka merged commit f77958c into trunk May 24, 2023
@mirka mirka deleted the ts/add-changelog branch May 24, 2023 08:27
@github-actions github-actions bot added this to the Gutenberg 15.9 milestone May 24, 2023
@tyxla
Copy link
Member

tyxla commented May 24, 2023

Sounds good, thank you both for confirming 👍

@cbravobernal cbravobernal added the [Type] Developer Documentation Documentation for developers label May 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Developer Documentation Documentation for developers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants