Block Toolbar: Fix text only label for locked blocks #50944
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mamaduka
added
[Type] Bug
Mamaduka
commented
May 25, 2023
Comment on lines
-57
to
-59
| &:focus::before { | ||
| right: $grid-unit-10 !important; | ||
| } |
There was a problem hiding this comment.
This is a hack for a narrow focus style, but it affected the text-only label. The default focus style looks good as well :)
|
I deeply wish we had time to do a full iteration on the labels only mode. It's lacking a lot of finesse, and as a result it's not as functional as it should be. In this case, here's the important "before" picture: 
This PR is better, but since the "unlock" button isn't a separate section, I'm not sure the vertical separator is a good solution. The fact that it says "Paragraph" and "Unlock Paragraph" next to each other in a toolbar that is contextual to the paragraph has a lot of redundancy that isn't helping the fact that labels-only already makes the block toolbar wider than it should be. Diving into ascii mockups, if we consider this is trunk: can we change that to this? I.e. just add a space, and parenthesis around the Unlock? |
|
Size Change: +7 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
carolinan
reviewed
May 25, 2023
I've also considered that, but since it wasn't applied to the drag handle, I thought we wanted separation for text labels. @joedolson suggested using "Unlock" for the label. I was thinking of a separate PR, but happy to handle that here.
The whole block toolbar styling needs refactoring to accommodate the current buttons. But, as you know, it's filled with hacks and workarounds. @carolinan, I don't like that either. I'll try to fix it, but CSS for the block-locking button is hacky enough and don't want to introduce more 😓 Screenshots
|
|
Flaky tests detected in 204bddc. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5129012394
|
|
@jasmussen, @carolinan, let me know if I can address any more feedback. |
Mamaduka
force-pushed
the
fix/unlock-block-text-only-toolbar-label
branch
from
feee8d5
to
204bddc
Compare
|
The label is updated now (#51083), and PR is ready for another round of tests. |
Mamaduka
force-pushed
the
fix/unlock-block-text-only-toolbar-label
branch
from
204bddc
to
f30362b
Compare
carolinan
approved these changes
Jun 13, 2023
Mamaduka
added
the
Backport to Gutenberg RC
ndiego
pushed a commit
that referenced
this pull request
Jun 13, 2023
ndiego
removed
the
Backport to Gutenberg RC
|
I just cherry-picked this PR to the release/16.0 branch to get it included in the next release: 7294485 |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #49865.
PR adjusts the styling of the text-only label for locked blocks.
Testing Instructions
Screenshots or screencast