Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DropdownMenu v2: change default placement to match the legacy DropdownMenu component #51133

Merged
merged 2 commits into from
May 31, 2023
Merged

DropdownMenu v2: change default placement to match the legacy DropdownMenu component #51133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01d15c5
Update docs
ciampo May 31, 2023
70352eb
CHANGELOG
ciampo May 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@
### Experimental

- `DropdownMenu` v2: Tweak styles ([#50967](https://github.com/WordPress/gutenberg/pull/50967), [#51097](https://github.com/WordPress/gutenberg/pull/51097)).
- `DropdownMenu` v2: change default placement to match the legacy `DropdownMenu` component ([#51133](https://github.com/WordPress/gutenberg/pull/51133)).
- `DropdownMenu` v2: Render in the default `Popover.Slot` ([#51046](https://github.com/WordPress/gutenberg/pull/51046)).

## 25.0.0 (2023-05-24)
Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/dropdown-menu-v2/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ The distance in pixels from the trigger.
The preferred alignment against the trigger. May change when collisions occur.

- Required: no
- Default: `"center"`
- Default: `"start"`

##### `alignOffset`: `number`

Expand Down
2 changes: 1 addition & 1 deletion packages/components/src/dropdown-menu-v2/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ export type DropdownMenuProps = {
* The preferred alignment against the trigger.
* May change when collisions occur.
*
* @default 'center'
* @default 'start'
*/
align?: DropdownMenuPrimitive.DropdownMenuContentProps[ 'align' ];
/**
Expand Down