Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use internal context system to apply toolbar variant to toolbar dropdowns #51154

Merged
merged 19 commits into from
Jun 8, 2023
Merged

Use internal context system to apply toolbar variant to toolbar dropdowns #51154

merged 19 commits into from
Jun 8, 2023

Commits on Jun 7, 2023

  1. DropdownMenu: read variant from context

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    a11b1ce View commit details
    Browse the repository at this point in the history

  2. Toolbar: do not set variant prop on popover (rely on context system… 

    … instead)
    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    2e4d820 View commit details
    Browse the repository at this point in the history

  3. Use named export for better storybook doc generation

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    e66a239 View commit details
    Browse the repository at this point in the history

  4. Provide context value in more toolbar components

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    ea25c42 View commit details
    Browse the repository at this point in the history

  5. Hook Dropdown into context system, update DropdownMenu and CircularOp… 

    …tionPicker
    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    69576a0 View commit details
    Browse the repository at this point in the history

  6. Remove toolbar variant popover prop where the context system can be u… 

    …sed instead
    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    46d70de View commit details
    Browse the repository at this point in the history

  7. Add comment where the context system currently doesn't work

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    fa9892c View commit details
    Browse the repository at this point in the history

  8. Use placement prop instead of legacy "position" prop

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    1937f31 View commit details
    Browse the repository at this point in the history

  9. Add some temporary TODO comments

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    a1b00c7 View commit details
    Browse the repository at this point in the history

  10. Set toolbar variant for Dropdown in the context system

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    1cecd36 View commit details
    Browse the repository at this point in the history

  11. Remove explicit variant prop from block alignment matrix control

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    b40411e View commit details
    Browse the repository at this point in the history

  12. Toolbar: Only set context in the top-level component

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    adcd28c View commit details
    Browse the repository at this point in the history

  13. Remove toolbar variant from instances using Dropdown

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    d3b23ce View commit details
    Browse the repository at this point in the history

  14. Simplify Dropdown implementation

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    1863132 View commit details
    Browse the repository at this point in the history

  15. Tidy up types

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    599f846 View commit details
    Browse the repository at this point in the history

  16. Remove toolbar variant storybook example for Popover

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    40adcd6 View commit details
    Browse the repository at this point in the history

  17. CHANGELOG

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    9ca6589 View commit details
    Browse the repository at this point in the history

  18. Complete renaming internal type

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    59d21e0 View commit details
    Browse the repository at this point in the history

  19. Remove duplicate hardcoded classnames(already added by context connexct)

    @ciampo
    ciampo committed Jun 7, 2023
    Configuration menu
    Copy the full SHA
    af98989 View commit details
    Browse the repository at this point in the history