Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image lightbox: Add support for external urls in the lightbox #51278

Merged
merged 1 commit into from
Jun 6, 2023
Merged

Image lightbox: Add support for external urls in the lightbox #51278

merged 1 commit into from
Jun 6, 2023

Conversation

SantosGuillamot
Copy link
Contributor

What?

Fixes #51276 : Image: Lightbox doesn't work on image inserted from URL.

Why?

Right now, the lightbox functionality, currently in experimental, doesn't work with image that point to an external url.

How?

I added a conditional that checks if the image id exists. If it does, the lightbox gets the URL from the attachment URL and, if not, it does use the external URL.

Testing Instructions

  • Enable the Interactivity API experiment in Gutenberg->Experiment.
  • Add an image with a source URL.
  • Check that the lightbox works as expected.

@SantosGuillamot SantosGuillamot added [Block] Image Affects the Image Block [Feature] Interactivity API API to add frontend interactivity to blocks. labels Jun 6, 2023
@SantosGuillamot SantosGuillamot mentioned this pull request Jun 6, 2023
Closed
artemiomorales
artemiomorales approved these changes Jun 6, 2023
View reviewed changes
Copy link
Contributor

@artemiomorales artemiomorales left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works and looks good to me 👍
We should also add a test for this. I'll do that in a follow up PR.

@artemiomorales artemiomorales merged commit 4ed9a02 into trunk Jun 6, 2023
@artemiomorales artemiomorales deleted the fix/image-lightbox-external-urls branch June 6, 2023 21:26
@github-actions github-actions bot added this to the Gutenberg 16.0 milestone Jun 6, 2023
@ndiego ndiego added the [Type] Experimental Experimental feature or API. label Jun 7, 2023
@artemiomorales artemiomorales mentioned this pull request Jun 7, 2023
Merged
@ramonjd ramonjd added the Needs PHP backport Needs PHP backport to Core label Jun 8, 2023
@ramonjd ramonjd mentioned this pull request Jun 8, 2023
Closed
@cbravobernal cbravobernal removed the Needs PHP backport Needs PHP backport to Core label Jun 15, 2023
sethrubenstein pushed a commit to pewresearch/gutenberg that referenced this pull request Jul 13, 2023
@SantosGuillamot @sethrubenstein
Add support for external urls in the lightbox (WordPress#51278)
ee5acb9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@artemiomorales artemiomorales artemiomorales approved these changes

@ajlende ajlende Awaiting requested review from ajlende

@spacedmonkey spacedmonkey Awaiting requested review from spacedmonkey spacedmonkey is a code owner

Assignees
No one assigned
Labels
[Block] Image Affects the Image Block [Feature] Interactivity API API to add frontend interactivity to blocks. [Type] Experimental Experimental feature or API.
Projects
None yet
Milestone
Gutenberg 16.0
Development

Successfully merging this pull request may close these issues.

Image: Lightbox doesn't work on image inserted from URL
5 participants
@SantosGuillamot @artemiomorales @ndiego @ramonjd @cbravobernal