Mobile - Image block - Fix issue with set width and height images #51463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geriux
added
[Status] In Progress
|
Size Change: +1.66 kB (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
geriux
added
the
Mobile App - Automation
|
Hey @SiobhyB 👋 I've added you as a reviewer for this PR let me know if you can take a look, thank you! |
|
Flaky tests detected in 07681a0. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5277592909
|
SiobhyB
approved these changes
Jun 15, 2023
There was a problem hiding this comment.
LGTM, thanks for fixing @geriux!
While testing, I noticed that switching between image sizes leads to Full Size images always taking up the full width of the block. I'd expect a Full Size image to alway display proportional to the image's actual size, as it is upon first opening the editor (with this fix applied). As this can be reproduced against trunk and is separate to how the block appears upon first load, I don't consider it a blocker to this PR, but maybe something relevant to address separately.
image-resize.mov
I can confirm that the main issue of image sometimes appearing cut off upon first load is now fixed, thanks again Gerardo! 👏 👏 🎉
|
Thanks for testing and reviewing!
Did the image have a set width value? Those values are used before using the size value that is set so for example when you change the size of the image on the mobile editor (Medium, Large, Full Size), it removes the previously set width and height values from the web editor. So it causes confusion 😅 Ideally, we should support having the width and height controls on the mobile editor. |
Yes, it was the image provided as part of the testing steps in this PR. So, against
@geriux, thanks for clarifying the root issue here! I agree that supporting the width and height controls in the native editor seems ideal. For the issue at hand, I think this PR is a good solution in the meantime. 🙇♀️ |
sethrubenstein
pushed a commit
to pewresearch/gutenberg
that referenced
this pull request
Jul 13, 2023
…rdPress#51463) * Mobile - Image block - Fix issue with set width and height images * Mobile - Update changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes wordpress-mobile/gutenberg-mobile#5091
What?
Fixes an issue with the Image block and set width and height values for some images.
Why?
To show the right aspect ratio regardless if the image has a set with/heigh value or not.
How?
By avoiding setting a set height value (from the container) if the image has a set width value.
Currently you can't set a custom width/height from the mobile editor but you can from the Web editor.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast