Navigation: Browse Mode: Fix misaligned ellipsis #51585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
scruffian
added
[Type] Bug
| @@ -22,7 +22,7 @@ export default function TemplatePartNavigationMenu( { id } ) { | |||
| size="12" | |||
| upperCase={ true } | |||
| > | |||
| { title || __( 'Navigation' ) } | |||
There was a problem hiding this comment.
Sneaky unrelated change?
|
I see the problem, but I'm not a fan of the "magic" numbers for pushing things around. Looks like the container for the ellipsis menu in the list view has a width of 24px, while the one next to the title is 36px. We could solve this by removing the padding on the ellipsis menu on the title. Something like |
|
Size Change: +167 B (0%) Total Size: 1.4 MB
ℹ️ View Unchanged
|
|
Flaky tests detected in 31f7c05. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/5290981957
|
I'm reluctant to do this as I assume that the ellipsis position in the title area is the correct one. My preference is to make the lower section wider to also give more space for longer navigation items, but I take your point that magic values aren't good. Closing this for now. |
|
There's a padding that makes the lower section narrower (in |
|
I think @jameskoster has driven some of those design efforts, and might be better equipped to answer. |
|
Some metrics may change for 6.3, but I don't sense a great deal of urgency around that, so they may not.
I think this is a good assumption. And so it makes most sense for the Navigation elements to align themselves with what already exists in the sidebar, rather than the other way around.
The remaining small misalignment is due to the ellipsis buttons using different size variants. The panel header uses the default size (36px) while the navigation menu item uses the small variant (24px). Could some logic be added to the navigation menu items to use the default size variant in the sidebar? That gets us to perfect alignment in a way that avoids magic numbers and should be backwards compatible: 
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Aligns the ellipsis menus in Browse mode.
Why?
So it looks better.
How?
Add some negative margins to the list view so it can use more of the screen canvas. Unfortunately using a grid value isn't possible as the value we need is between grid values.
Testing Instructions
Testing Instructions for Keyboard
N/A. This is a visual change
Screenshots or screencast