Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation: Refactor the PHP render function to make it easier to make changes in the future #55605

Merged
merged 61 commits into from
Nov 9, 2023
Merged

Navigation: Refactor the PHP render function to make it easier to make changes in the future #55605

merged 61 commits into from
Nov 9, 2023

Commits on Nov 2, 2023

  1. Navigation: Refactor the PHP render function to make it easier to mak… 

    …e changes in the future
    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    65f5793 View commit details
    Browse the repository at this point in the history

  2. move code to get_inner_blocks_html

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5bcde61 View commit details
    Browse the repository at this point in the history

  3. remove is-fallback class

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    dcd97b7 View commit details
    Browse the repository at this point in the history

  4. allow multiple menus

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    e268651 View commit details
    Browse the repository at this point in the history

  5. add some comments

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    8f54d44 View commit details
    Browse the repository at this point in the history

  6. refactor directives to a different function

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a9f0328 View commit details
    Browse the repository at this point in the history

  7. fix submenus

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    f087c4e View commit details
    Browse the repository at this point in the history

  8. refactor responseive navigation function

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    b40caa5 View commit details
    Browse the repository at this point in the history

  9. remove a passed param

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    a6ffa85 View commit details
    Browse the repository at this point in the history

  10. create a function for get_styles

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    2991d1e View commit details
    Browse the repository at this point in the history

  11. dont pass the container_attributes as a param

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    afe3474 View commit details
    Browse the repository at this point in the history

  12. handle view script loading

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    58906ca View commit details
    Browse the repository at this point in the history

  13. reorder code

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    67d5ec3 View commit details
    Browse the repository at this point in the history

  14. simplify the return

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    40c4cce View commit details
    Browse the repository at this point in the history

  15. tidy up the wrapper attributes

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    0544d33 View commit details
    Browse the repository at this point in the history

  16. remove one dependence on has_submenu

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    21e973d View commit details
    Browse the repository at this point in the history

  17. remove the should load view script variable

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    c7e010a View commit details
    Browse the repository at this point in the history

  18. more simplification

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    001ed21 View commit details
    Browse the repository at this point in the history

  19. Update packages/block-library/src/navigation/index.php 

    Co-authored-by: Dave Smith <[email protected]>
    @scruffian @getdave
    scruffian and getdave committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    e8b57df View commit details
    Browse the repository at this point in the history

  20. rename class

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7826b78 View commit details
    Browse the repository at this point in the history

  21. remname is_responsive_navigation

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    dc5fb2c View commit details
    Browse the repository at this point in the history

  22. rename does_navigation_have_submenus

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    0a7c0d1 View commit details
    Browse the repository at this point in the history

  23. rename get_inner_blocks_for_navigation

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    362d7bd View commit details
    Browse the repository at this point in the history

  24. rename get_layout_class_for_navigation

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    04f245e View commit details
    Browse the repository at this point in the history

  25. Update packages/block-library/src/navigation/index.php 

    Co-authored-by: Dave Smith <[email protected]>
    @scruffian @getdave
    scruffian and getdave committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    7123f27 View commit details
    Browse the repository at this point in the history

  26. Update packages/block-library/src/navigation/index.php 

    Co-authored-by: Dave Smith <[email protected]>
    @scruffian @getdave
    scruffian and getdave committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    af5f8cd View commit details
    Browse the repository at this point in the history

  27. change name of get_nav_markup

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5157393 View commit details
    Browse the repository at this point in the history

  28. split get_inner_blocks into smaller functions

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    cd2c7fd View commit details
    Browse the repository at this point in the history

  29. add comment

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5514082 View commit details
    Browse the repository at this point in the history

  30. remove unnecessary spaces

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    34fde64 View commit details
    Browse the repository at this point in the history

  31. update docs

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    8998c2b View commit details
    Browse the repository at this point in the history

  32. reverse parameter order

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    62d192f View commit details
    Browse the repository at this point in the history

  33. reverse parameter order

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    fdabfa4 View commit details
    Browse the repository at this point in the history

  34. reverse parameter order

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    1ae2f05 View commit details
    Browse the repository at this point in the history

  35. move the class to a new file

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    5ab9ae5 View commit details
    Browse the repository at this point in the history

  36. add docs

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    d51d7c3 View commit details
    Browse the repository at this point in the history

  37. rename to

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    9a7a313 View commit details
    Browse the repository at this point in the history

  38. move function that's only used by the plugin into that section of the… 

    … code
    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    70cf09b View commit details
    Browse the repository at this point in the history

  39. fix linter

    @scruffian
    scruffian committed Nov 2, 2023
    Configuration menu
    Copy the full SHA
    643c967 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. reference the class internally using static

    @scruffian
    scruffian committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    d3c876b View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. move variable to static variables

    @scruffian
    scruffian committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    736e27d View commit details
    Browse the repository at this point in the history

  2. Update lib/compat/wordpress-6.5/class-wp-navigation-block-renderer.php 

    Co-authored-by: Dave Smith <[email protected]>
    @scruffian @getdave
    scruffian and getdave authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    dcad41f View commit details
    Browse the repository at this point in the history

  3. Update lib/compat/wordpress-6.5/class-wp-navigation-block-renderer.php 

    Co-authored-by: Dave Smith <[email protected]>
    @scruffian @getdave
    scruffian and getdave authored Nov 7, 2023
    Configuration menu
    Copy the full SHA
    07f65eb View commit details
    Browse the repository at this point in the history

  4. move the logic for inner block rendering to a separate function

    @scruffian
    scruffian committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    103c27a View commit details
    Browse the repository at this point in the history

  5. test for navigation link markup

    @MaggieCabrera
    MaggieCabrera committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    d98037e View commit details
    Browse the repository at this point in the history

  6. test for site title markup

    @MaggieCabrera
    MaggieCabrera committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    a19a890 View commit details
    Browse the repository at this point in the history

  7. removed comments, changed assertSame to assertEquals

    @MaggieCabrera
    MaggieCabrera committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    c5261b6 View commit details
    Browse the repository at this point in the history

  8. format php

    @MaggieCabrera
    MaggieCabrera committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    0e63a3a View commit details
    Browse the repository at this point in the history

  9. hide the condition in a function

    @scruffian
    scruffian committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    295bd03 View commit details
    Browse the repository at this point in the history

  10. hide the condition in a function

    @scruffian
    scruffian committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    94dd338 View commit details
    Browse the repository at this point in the history

  11. return early from has_submenus

    @scruffian
    scruffian committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    939c50f View commit details
    Browse the repository at this point in the history

  12. comments for the tests

    @MaggieCabrera
    MaggieCabrera committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    d21547c View commit details
    Browse the repository at this point in the history

  13. create a function to get the name

    @scruffian
    scruffian committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    b16a3bd View commit details
    Browse the repository at this point in the history

  14. rename variable to nav_blocks_wrapped_in_list_item

    @scruffian
    scruffian committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    aceed2e View commit details
    Browse the repository at this point in the history

  15. phpcs

    @scruffian
    scruffian committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    05ab18f View commit details
    Browse the repository at this point in the history

  16. phpcs

    @scruffian
    scruffian committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    5310ede View commit details
    Browse the repository at this point in the history

Commits on Nov 8, 2023

  1. Update phpunit/class-wp-navigation-block-renderer-test.php 

    Co-authored-by: Dave Smith <[email protected]>
    @MaggieCabrera @getdave
    MaggieCabrera and getdave authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    163f08f View commit details
    Browse the repository at this point in the history

  2. Update phpunit/class-wp-navigation-block-renderer-test.php

    @MaggieCabrera
    MaggieCabrera authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    649f813 View commit details
    Browse the repository at this point in the history

  3. Update phpunit/class-wp-navigation-block-renderer-test.php

    @MaggieCabrera
    MaggieCabrera authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    73764c9 View commit details
    Browse the repository at this point in the history

  4. Apply suggestions from code review 

    Co-authored-by: Dave Smith <[email protected]>
    @MaggieCabrera @getdave
    MaggieCabrera and getdave authored Nov 8, 2023
    Configuration menu
    Copy the full SHA
    9b669a1 View commit details
    Browse the repository at this point in the history

  5. dynamic url for links on test

    @MaggieCabrera
    MaggieCabrera committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    c56237d View commit details
    Browse the repository at this point in the history