Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix fatal error in WP_Fonts_Resolver::get_settings() #55981

Merged
merged 4 commits into from
Nov 10, 2023
Merged

Fix fatal error in WP_Fonts_Resolver::get_settings() #55981

merged 4 commits into from
Nov 10, 2023

Commits on Nov 8, 2023

  1. Check variables before passing them to array_merge. 

    array_merge() expects input parameters to be arrays.
    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    5e88c36 View commit details
    Browse the repository at this point in the history

  2. Fix the comment.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Nov 8, 2023
    Configuration menu
    Copy the full SHA
    5737291 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Optimization: don't check for the existence of $settings['typography'… 

    …]['fontFamilies']['theme'] on every iteration of the loop.
    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    8e94c1c View commit details
    Browse the repository at this point in the history

  2. Optimization: ternary is not needed here.

    @anton-vlasenko
    anton-vlasenko authored and Anton Vlasenko committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    061bafb View commit details
    Browse the repository at this point in the history