Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Design Tools: Add section based styling via theme.json #56234

Closed
wants to merge 23 commits into from
Closed

[WIP] Design Tools: Add section based styling via theme.json #56234

wants to merge 23 commits into from

Commits on Nov 20, 2023

  1. Draft generation of section styles from theme.json

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    c3a7233 View commit details
    Browse the repository at this point in the history

  2. Move section block node generation to get_block_nodes

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    f0fc4e1 View commit details
    Browse the repository at this point in the history

  3. Add section class to blocks in the editor

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    7f54bb0 View commit details
    Browse the repository at this point in the history

  4. Add section inspector controls group

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    a2b97c2 View commit details
    Browse the repository at this point in the history

  5. Include section inspector controls group

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    b21508f View commit details
    Browse the repository at this point in the history

  6. Add overly simplistic control to set section attribute

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    85fc9ac View commit details
    Browse the repository at this point in the history

  7. Hack at the Global Styles Output hook to get semi functional

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    9b2a306 View commit details
    Browse the repository at this point in the history

  8. Fix section block element scoping

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    ed0146b View commit details
    Browse the repository at this point in the history

  9. Try refactoring style node generation

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    efb279e View commit details
    Browse the repository at this point in the history

  10. Try refactoring PHP theme.json block node generation

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    79b58ff View commit details
    Browse the repository at this point in the history

  11. Fix useGlobalStylesOutput test

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    196fe52 View commit details
    Browse the repository at this point in the history

  12. Quick hack to add global styles data to block editor settings

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    d6640f5 View commit details
    Browse the repository at this point in the history

  13. Replace text control to set section index on attributes

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    86bddfc View commit details
    Browse the repository at this point in the history

  14. Revert "Replace text control to set section index on attributes" 

    This reverts commit bc6d240.
    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    8d6bf92 View commit details
    Browse the repository at this point in the history

  15. Switch section styles to use SelectControl

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    67f0dcc View commit details
    Browse the repository at this point in the history

  16. Fix linting errors

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    16fdbf1 View commit details
    Browse the repository at this point in the history

  17. Update stylesheet generation test to include section styles 

    Also fixes incorrect font family and sizes config in stylesheet test
    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    ac8ab80 View commit details
    Browse the repository at this point in the history

  18. Add some quick tests for section styles

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    2127f17 View commit details
    Browse the repository at this point in the history

  19. Clean up section class application

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    fd9b6de View commit details
    Browse the repository at this point in the history

  20. Try completing fallback logic for section class in the editor 

    Turns out this approach relies on block's plumbing the className prop through to their wrappers. Will keep commit and revert it as reference to approach that can actually use useSelect to fetch sections data.
    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    808a829 View commit details
    Browse the repository at this point in the history

  21. Revert "Try completing fallback logic for section class in the editor" 

    This reverts commit 11c2c5072a7e68597bfc8594ab0ce00bf58e8958.
    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    e282885 View commit details
    Browse the repository at this point in the history

  22. Complete section class fallback in the editor

    @aaronrobertshaw
    aaronrobertshaw committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    122da37 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2023

  1. Fix allow list for section support in editor

    @aaronrobertshaw
    aaronrobertshaw committed Nov 21, 2023
    Configuration menu
    Copy the full SHA
    cecdfd9 View commit details
    Browse the repository at this point in the history