Site Editor: Add a fallback template showing the title and content for the post only mode. #56509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r the post only mode
youknowriad
added
the
[Type] Bug
|
Size Change: -31 B (0%) Total Size: 1.7 MB
ℹ️ View Unchanged
|
ramonjd
approved these changes
Nov 27, 2023
andrewserong
approved these changes
Nov 27, 2023
There was a problem hiding this comment.
Nice, this feels like a good default to me, too!
One potential issue to smooth out (but not a blocker for this PR as it's only partly related) is what we do with the content only mode when you initially go into a page that doesn't have any content blocks. If you have the list view open by default, it appears empty, and if you click anywhere on the page, you're nudged to switch to template editing mode. I'm not too sure what the best behaviour would be here, but in any case, the user can either go to edit their template, or switch the template preview mode off if they wish to edit the content for the page directly:
2023-11-27.12.42.07.mp4
🤔
This change LGTM, though! ✨
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related #52632
Follow-up #56418
What?
If your page is using a template with a query loop block rather than using directly post title and post content, disabling the template preview (under "template" panel in the sidebar) resulted in a white page because no post blocks were found in the template.
This PR adds a fallback showing the post title and post content of the page (kind of mimicking the post editor).
My ultimate goal (not sure how possible) is to make the "post-only" mode strictly equivalent to the post editor which would allow us to refactor the post editor to use it instead of handing the switching between template and post manually.
Testing instructions