-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Editor: Move the Excerpt panel to the editor package #57096
Conversation
Size Change: +110 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
Flaky tests detected in 2476821. 🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/7219575593
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good to me as well!
Related #52632
What?
This PR continues the work on the great unification between post and site editors. This PR moves the PostExcerpt panel from the edit-post package to the editor package and reuse the same panel in the site editor as well. This means that this brings supports to excerpt to the site editor sidebar for post types that support it, similar to the post editor.
The problem though is that we have wp_template and wp_template_part that actually support excerpts but through a different REST API key "description" and I'm guessing that for these we'd also want to say "Description" in the UI rather than "Excerpt". This means, that for now, we can't use the same panel/UI I forced support to false for these post types. This also means there's actually no post type that is currently rendered in the site editor that supports excerpts.
Testing instructions