Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TabPanel: refactor unit tests to @ariakit/test #57302

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

ciampo
Copy link
Contributor

@ciampo ciampo commented Dec 21, 2023

Same as #56835 but for TabPanel, mostly to reduce some flakiness that I noticed while running tests

@ciampo ciampo requested review from tyxla and a team December 21, 2023 11:13
@ciampo ciampo self-assigned this Dec 21, 2023
@ciampo ciampo added [Type] Enhancement A suggestion for improvement. [Package] Components /packages/components labels Dec 21, 2023
Copy link
Member

@tyxla tyxla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quite straightforward. Thanks, looks good, let's ship 🚀

}

await cleanupTooltip( user );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ciampo ciampo merged commit 51b81ef into trunk Dec 22, 2023
59 of 62 checks passed
@ciampo ciampo deleted the refactor/tab-panel-ariakit-test branch December 22, 2023 07:14
@github-actions github-actions bot added this to the Gutenberg 17.4 milestone Dec 22, 2023
@bph bph added the [Type] Code Quality Issues or PRs that relate to code quality label Dec 27, 2023
@ciampo ciampo removed the [Type] Enhancement A suggestion for improvement. label Jan 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Package] Components /packages/components [Type] Code Quality Issues or PRs that relate to code quality
Projects
Status: Done 🎉
Development

Successfully merging this pull request may close these issues.

3 participants