-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataViews: add front page to pages page sidebar #57759
Conversation
Size Change: +39 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
Copying my comment from the original conversation: #57690 (comment)
Essentially, I think we should go with this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems to be working well. Front Page is included when the homepage is set to display latest posts. This falls back to Blog Home if Front Page isn't found.
Ok, let's go with this one and put #57758 in the back burner for now. |
Part of #55083
Follow-up to #57578 and #57690
Alternative to #57758
What?
Adds the
Front Page
to the sidebar of the Pages page, together with404
andSearch
.Why?
The existing pages page has a few things other than the pages: the
404
&Search
templates, as well as the template for theFront Page
. This has been done probably for findability: let users know that these are "pages" even if they don't create them.We need to figure out where or whether they still make sense in a dataviews-powered page.
An alternative approach is to show them as part of the list of pages. #57758 is a proof of concept to explore that instead.
How?
Adds the
Front page
to the sidebar.Testing Instructions