Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout block supports use str_contains #58251

Merged
merged 1 commit into from
Jan 30, 2024

Conversation

getdave
Copy link
Contributor

@getdave getdave commented Jan 25, 2024

What?

Makes changes suggested in per WordPress/wordpress-develop#5935 (comment).

Once merged I will update the Core PR to target this Gutenberg PR.

Why?

During the sync commit for #56171 changes were requested in order to merge to WP Core. This PR backports those changes to Gutenberg.

As @dmsnell suggested it would be easier to commit the change to Gutenberg first and then proceed.

How?

Uses str_contains.

Testing Instructions

Testing Instructions for Keyboard

Screenshots or screencast

@getdave getdave added [Type] Code Quality Issues or PRs that relate to code quality Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core labels Jan 25, 2024
@getdave getdave self-assigned this Jan 25, 2024
@getdave getdave changed the title Use str_contains as per Core version Backport changes to layout block supports from WP Core Jan 25, 2024
@getdave
Copy link
Contributor Author

getdave commented Jan 25, 2024

@youknowriad Core supports str_contains since 5.9 so I think we're safe to use this.

We do not want to merge this change until after WordPress/wordpress-develop#5935 is committed to WP Core.

Copy link

This pull request has changed or added PHP files. Please confirm whether these changes need to be synced to WordPress Core, and therefore featured in the next release of WordPress.

If so, it is recommended to create a new Trac ticket and submit a pull request to the WordPress Core Github repository soon after this pull request is merged.

If you're unsure, you can always ask for help in the #core-editor channel in WordPress Slack.

Thank you! ❤️

View changed files
❔ lib/block-supports/layout.php

@getdave getdave changed the title Backport changes to layout block supports from WP Core Layout block supports use str_contains Jan 26, 2024
@getdave getdave added Needs PHP backport Needs PHP backport to Core and removed Backport from WordPress Core Pull request that needs to be backported to a Gutenberg release from WordPress Core labels Jan 26, 2024
@getdave getdave marked this pull request as ready for review January 26, 2024 11:20
Copy link
Member

@dmsnell dmsnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was already approved in the previous PR, and it looks solid.

@getdave getdave merged commit 40ec1e3 into trunk Jan 30, 2024
58 of 63 checks passed
@getdave getdave deleted the backport/layout-support-from-wp-core branch January 30, 2024 09:48
@github-actions github-actions bot added this to the Gutenberg 17.7 milestone Jan 30, 2024
getdave added a commit to getdave/wordpress-develop that referenced this pull request Jan 30, 2024
@youknowriad youknowriad added Backported to WP Core Pull request that has been successfully merged into WP Core and removed Needs PHP backport Needs PHP backport to Core labels Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backported to WP Core Pull request that has been successfully merged into WP Core [Type] Code Quality Issues or PRs that relate to code quality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants