Experiment: Allow editing of custom fields in block bindings #58723
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SantosGuillamot
added
[Type] Experimental
|
Size Change: +74 B (0%) Total Size: 1.69 MB
ℹ️ View Unchanged
|
retrofox
reviewed
Feb 6, 2024
| if ( boundAttributes[ attributeName ] ) { | ||
| const { | ||
| placeholder, | ||
| useValue: [ sourceValue = null ] = [], |
There was a problem hiding this comment.
sourceValue > metaValue. I'd suggest sourcePropValue as well.
This was referenced Feb 8, 2024
retrofox
reviewed
Feb 13, 2024
Comment on lines
+123
to
+127
| setAttributes={ ( newAttributes ) => { | ||
| registry.batch( () => | ||
| updatedSetAttributes( newAttributes ) | ||
| ); | ||
| } } |
There was a problem hiding this comment.
If I'm right, this scenario will cover the case when the attributes are edited from the BlockEdit function representation. This means that if, for instance, you change the attribute value by dispatching an action, the updatedSetAttribute will never be called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP
I'm creating this pull request to test different approaches to enable the editing of custom field. Bear in mind that this hasn't been even tested.
What?
Experimental code to discuss different approach to be able to edit the value of the custom fields when using block bindings.
Why?
Testing Instructions