List view: fix stuck moving animation on Enter #59644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ellatrix
added
[Type] Bug
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Size Change: +8 B (0%) Total Size: 1.71 MB
ℹ️ View Unchanged
|
|
Oh, nice, this looks promising! I'll take this for a spin later on today. |
andrewserong
approved these changes
Mar 7, 2024
|
WP 6.5 release leads - contributors believe this PR is sufficiently important that it should be included in the final release. The rationale is presented here. @andrewserong and @ellatrix may be able to add additional context that I"m not aware of. |
getdave
pushed a commit
that referenced
this pull request
Mar 11, 2024
Co-authored-by: ellatrix <[email protected]> Co-authored-by: andrewserong <[email protected]>
|
I just cherry-picked this PR to the pick/wp-65-rc-2 branch to get it included in the next release: c66577a |
getdave
added
Backported to WP Core
getdave
pushed a commit
that referenced
this pull request
Mar 12, 2024
Co-authored-by: ellatrix <[email protected]> Co-authored-by: andrewserong <[email protected]>
bph
added
[Package] Block editor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Fixes #59481.
Alternative to #59482.
controller.stop()seems to merely stop the animation without resetting it to the end position. We can usecontroller.set( { x: 0, y: 0 } )to make the animation also finish immediately. I didn't see any alternative tostopto do both in the docs.Why?
How?
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast