Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry Pick changes for WordPress 6.5 RC3 #59949

Merged
merged 9 commits into from
Mar 18, 2024
Merged

Cherry Pick changes for WordPress 6.5 RC3 #59949

merged 9 commits into from
Mar 18, 2024

Commits on Mar 18, 2024

  1. Prevent default on primary+k to prevent command center from opening (#… 

    …59845)

The command center shortcut checks for defaultPrevented to see if it should open or not. To prevent the command center from opening, we need to add event.preventDefault when primary+k is used.
    @jeryj @youknowriad
    jeryj authored and youknowriad committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    31ac517 View commit details
    Browse the repository at this point in the history

  2. Ensure consistent return type in `WP_Navigation_Block_Renderer::get_m… 

    …arkup_for_inner_block()` (#59820)

* Fix for #59814

Fixes get_markup_for_inner_block()

* fix WPCS issues
    @afragen @youknowriad
    afragen authored and youknowriad committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    ad56431 View commit details
    Browse the repository at this point in the history

  3. Do not focus new navigation block menu until loading is finished (#59801 

    )

* Do not focus navigation block until loading is finished

When a new navigation is created, we place focus on the navigation block. If we place focus while loading is still happening, focus will be lost when focus the loading is finished and the block gets replaced with the new content.

* Nest loading state inside of navigation ref

Instead of replacing the navigation block after loading, only replace the inside part of it so that focus is not lost

* Add coverage for focus loss on menu creation

* select the navigatiom after import in an effect similar to the method used when creating a menu, this way the select block call is later and the focus is maintained

* remove extraneous dependency causing err on delete newly created menus

* Update test to not determine link control behavior

* No need to return await inside an async function as it will always return a Promise

Co-authored-by: Dave Smith <[email protected]>

---------

Co-authored-by: Andrei Draganescu <[email protected]>
Co-authored-by: Dave Smith <[email protected]>
    @jeryj @draganescu
    @getdave @youknowriad
    3 people authored and youknowriad committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    1d93d98 View commit details
    Browse the repository at this point in the history

  4. Interactivity: Ensure stores are initialized on client (#59842) 

    If a store call happens after interactivity has hydrated, subscriptions may not be made correctly which means that when a store is later added, the subscriptions do not exist and the client will not update. This is undesirable.

We fix this by creating empty stores during directive resolution, ensuring subscriptions can be made so that subsequent store changes will update the client.
    @sirreal @youknowriad
    sirreal authored and youknowriad committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    c0b82c4 View commit details
    Browse the repository at this point in the history

  5. Block Hooks: Return early from saving meta data for the navigation wi… 

    …thout a $post->ID (#59875)

Co-authored-by: Bernie Reiter <[email protected]>
Co-authored-by: Hugo Drelon <[email protected]>
    @tjcafferkey @ockham
    @Hug0-Drelon @youknowriad
    3 people authored and youknowriad committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    ce4250a View commit details
    Browse the repository at this point in the history

  6. Interactivity API: Prevent non-object state from being added (#59886) 

    Ensure that `state` is an object when creating a store for a given namespace.

`store.state` is expected to be an object. There is code that prevents state from being updated if it is not an object, but it's possible to set the state to a non-object initially, which breaks subsequent updates.

Co-authored-by: sirreal <[email protected]>
Co-authored-by: DAreRodz <[email protected]>
    @sirreal @youknowriad
    3 people authored and youknowriad committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    6421202 View commit details
    Browse the repository at this point in the history

  7. avoid auto-removing system fonts (#59910)

    @matiasbenedetto @youknowriad
    matiasbenedetto authored and youknowriad committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    14fef7b View commit details
    Browse the repository at this point in the history

  8. Heading Block: Show default block name in list view when content is e… 

    …mpty (#59827)


Co-authored-by: t-hamano <[email protected]>
Co-authored-by: Mamaduka <[email protected]>
Co-authored-by: andrewserong <[email protected]>
Co-authored-by: getdave <[email protected]>
    @t-hamano @Mamaduka
    @andrewserong @getdave @youknowriad
    5 people authored and youknowriad committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    c20a56d View commit details
    Browse the repository at this point in the history

  9. Font Library: fix JS errors when activating or deactivating system fo… 

    …nts (#59935)

Co-authored-by: creativecoder <[email protected]>
Co-authored-by: madhusudhand <[email protected]>
Co-authored-by: mikachan <[email protected]>
    @creativecoder @mikachan @youknowriad
    4 people authored and youknowriad committed Mar 18, 2024
    Configuration menu
    Copy the full SHA
    e4337f2 View commit details
    Browse the repository at this point in the history