Cherry picked nine prs for Release/18.0 RC2 #60216
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected] - @wordpress/[email protected]
* use globalStyles + theme.json base files to render a list of avialble fonts in the font library modal. Avoid fonts with duplicated slugs. * add comments * improve comment * fix typo in comment Co-authored-by: Grant Kinney <[email protected]> --------- Co-authored-by: matiasbenedetto <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: mikachan <[email protected]> Co-authored-by: creativecoder <[email protected]>
…dited (#60071) Co-authored-by: Mamaduka <[email protected]> Co-authored-by: jsnajdr <[email protected]> Co-authored-by: annezazu <[email protected]>
…60130) Unlinked contributors: ariel-maidana. Co-authored-by: draganescu <[email protected]> Co-authored-by: scruffian <[email protected]> Co-authored-by: SantosGuillamot <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: fabiankaegy <[email protected]> Co-authored-by: huzaifaalmesbah <[email protected]> Co-authored-by: kjnanda <[email protected]> Co-authored-by: youknowriad <[email protected]> Co-authored-by: colorful-tones <[email protected]> Co-authored-by: liviopv <[email protected]>
Co-authored-by: jsnajdr <[email protected]> Co-authored-by: mcsf <[email protected]> Co-authored-by: annezazu <[email protected]> Co-authored-by: youknowriad <[email protected]>
…#60180) * Font Library: install fonts in sequence to work around font directory race condition * Update comment block to coding standards Co-authored-by: Peter Wilson <[email protected]> * Fix linting --------- Co-authored-by: creativecoder <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: mcsf <[email protected]> Co-authored-by: peterwilsoncc <[email protected]> Co-authored-by: mikachan <[email protected]> Co-authored-by: huzaifaalmesbah <[email protected]> Co-authored-by: t-hamano <[email protected]> Co-authored-by: swissspidy <[email protected]> Co-authored-by: kjnanda <[email protected]> Co-authored-by: matiasbenedetto <[email protected]>
…frontend (#60093) * Activate the fonts coming from the backend and not the data from the frontend * add comment ----- Co-authored-by: matiasbenedetto <[email protected]> Co-authored-by: mikachan <[email protected]> Co-authored-by: getdave <[email protected]> Co-authored-by: mcsf <[email protected]> Co-authored-by: carolinan <[email protected]> Co-authored-by: huzaifaalmesbah <[email protected]> Co-authored-by: srueegger <[email protected]> Co-authored-by: annezazu <[email protected]>
bph
requested review from
ObliviousHarmony,
t-hamano,
ellatrix,
fluiddot,
dcalhoun,
gziolo,
adamsilverstein,
talldan,
swissspidy,
ajitbohra,
peterwilsoncc,
ntwb,
nerrad,
ryanwelcher,
kevin940726,
luisherranz and
DAreRodz
as code owners
bph
requested review from
draganescu,
adamziel,
dmsnell,
atimmer,
mmtr,
juanmaguitar,
fabiankaegy and
ndiego
as code owners
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @gutenbergplugin. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Warning: Type of PR label mismatch To merge this PR, it requires exactly 1 label indicating the type of PR. Other labels are optional and not being checked here.
Read more about Type labels in Gutenberg. Don't worry if you don't have the required permissions to add labels; the PR reviewer should be able to help with the task. |
bph
added
Backport to Gutenberg RC
getdave
added
the
[Type] Task
getdave
requested changes
Mar 26, 2024
There was a problem hiding this comment.
This PR is picking changes into trunk. However, I believe the commits are already on the release/18.0 branch:
https://github.com/WordPress/gutenberg/tree/release/18.0
Not sure what happened. Maybe automation?
|
Looking at the docs that’s [the commits picked directly into the release branch] expected behaviour. You don’t need to raise a PR to cherry pick the changes. So unless I’m mistaken we can close this one out and all you need do is run the RC release. |
getdave
removed
the
Backport to Gutenberg RC
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What?
Cherry-picked these PRs
#59959 – 6e614c5 – Fix list of base theme fonts w...
#60071 – 7b6ac8d – Navigation: Avoid content loss...
#60130 – f217ef0 – Fix self closing navigation ov...
#60162 – dbd4cec – Fix code formatting in Nav blo...
#60167 – 447c008 – Fix root ID calculation when c...
#60187 – 1d7407b – Featured Image: Fix overlay re...
#60184 – 90907af – Featured Image: Fix block supp...
#60180 – f9effe4 – Font Library: install fonts in...
#60093 – d158d9b – Activate the fonts coming from...
Why?
In preparation for 18.0 RC2